Offering to co-maintain Floating Block

I've sent an email to @diqidoq.

Hello MegaChriz

Do you by any chance have a D10 compatible version of this module that I can use. I desperately needed for a project. I will really appreciate it.

@elbarcino
Yes. Do you manage your Drupal site with Composer? If so:

• Make sure you have the following in the "require" section of your composer.json:
  

  "cweagans/composer-patches": "^1.7",
  "mglaman/composer-drupal-lenient": "^1.0",
  

• And in extra > patches:

  "drupal/floating_block": {
      "D10 support": "https://www.drupal.org/files/issues/2023-08-11/floating_block-d10-3287625-20230307.patch"
  }
  

• And in extra > drupal-lenient > allowed-list:

  "drupal/floating_block"
  

Attached an example composer.json so you can see more clearly where to put what.

@MegaChriz

Thanks for your reply.

Is there a way of download and manually install it? I prefer not to touch the composer file at this point...

Yes you could download the project: https://ftp.drupal.org/files/projects/floating_block-2.0.0-beta1.tar.gz
And then apply the following patch on it: https://www.drupal.org/files/issues/2023-08-11/floating_block-d10-328762... →

Applying the patch: on the command line, go to the floating_block folder and then execute the following command:

patch -p1 < floating_block-d10-3287625-20230307.patch

In the command above the patch file is in the floating_block folder.

For more information about applying patches, see https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →

Because it has been a while that I sent @diqidoq a message about this issue, I just sent him another one:

Hello diqidoq,

A while ago I requested maintainership for the Floating Block module in order to make it Drupal 10 ready:
https://www.drupal.org/project/floating_block/issues/3359774 💬 Offering to co-maintain Floating Block Active

Do you want to let me know if you'd like me as a (co-)maintainer or not?

Regards,

Youri

@MegaChriz

Thanks for the code. It works perfectly well.

I've now sent this message to one of the other maintainers, alexpott:

Hello Alex,

I would like to become co-maintainer of the Floating Block module in order to make it Drupal 10 ready.
Here is the issue about this request: https://www.drupal.org/project/floating_block/issues/3359774 💬 Offering to co-maintain Floating Block Active

I've tried to contact the maintainer "diqidoq" a few times, because he seemed to be the last active maintainer on this project, but I got no response so far from him.

Regards,

Youri

@MegaChriz I've just released 2.0.0-beta2

I think we need to do:
📌 Add javascript test coverage Fixed
📌 Fix eslint and stylelint issue Active

Before we release 2.0.0.

If you get both of those done then Im happy to make you a maintainer.

@alexpott
Thanks for the update and the release! I shall see what I can do to fix these other two issues.

I provided MR's for 📌 Add javascript test coverage Fixed and 📌 Fix eslint and stylelint issue Active .

@MegaChriz: I feel very sorry for that I have not recognized the messages you send me to my Drupal mail in my spare time soon enough and that I had no time yet to reply here or to your messages later. I feel absolutely comfortable with you being a co-maintainer of this project from my viewpoint but it is not up to me as the last entered co-maintainer here for just 3 years to decide this. So at least my feel for responsibility on projects and their health. I jumped in to help here in the issue queue and to not push things too much single-handedly on my own.

@alexpott: I would like to chime in here to confirm the very supportive contributions and help provided by @MegaChriz in the last years in the issue queue of Floating Block and on Slack and I think it is a good idea to let him jump into the boat if he adds his support carefully ;-)

@MegaChriz: For example please do not mix issues. Since this issue here was about maintainerchip you should have guided the user elbarcino asking you for help to another related or a new issue related to his question.

Thanks for responding @diqidoq! I can understand that you were not able to reply earlier and I don't blame you for it. I have experienced myself too that I took a long time to reply to someone because there was too much else going on.

I agree it would've been better for maintainability of the issue queue if my reply to @elbarcino was handled in an other issue. I guess I wanted to help him/her in the quickest way possible. But I see that it was off topic for this issue.

2) I'm not a javascript expert, but I am good in testing and writing tests and in backend. I may not be able to resolve all javascript related issues that come up in this issue queue, but I should at least be able to get the module compatible with future Drupal versions and expand test coverage, if needed.

@MegaChriz welcome to Floating block maintainership. Well earned after the work on adding tests and the code quality pipeline. Thanks! Obviously this module is in maintenance mode and you've done a lot of that recently so that's great. Any concerns please ping either me or @diqidoq in slack.

Thank you!

Automatically closed - issue fixed for 2 weeks with no activity.