- Issue created by @Anybody
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @anybody opened merge request.
- Assigned to thomas.frobieter
- Status changed to Needs review
over 1 year ago 9:10am 11 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter seems to be working fine! Please review. You can see the results in D10VL - code is 1:1
- 🇩🇪Germany Anybody Porta Westfalica
No further drupal_image() calls in this project!
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter: I guess this should be reviewed and merged. Sadly, I think this isn't present in D10VL anymore, but we can patch it in.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter: This is even more important, as I just found out that the old implementation is losing all
alt
tags on images. I replaced the twig file at GS and the output is 100% the same, just without the missing attributes.Could you please review, merge and tag a new release here with priority? Thanks :)
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter yes, @Grevil tried that and we have an automated test in place. But happy to give it a try yourself.
Still note, that it should be used with care and only when needed as there might be double-initialization possible. Any of course a non-global initialization is always better (field etc.)
- Status changed to RTBC
over 1 year ago 10:51am 8 August 2023 - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass -
thomas.frobieter →
committed 25a0340d on 3.x authored by
Anybody →
Issue #3359595 by Anybody: Replace twig_tweak's drupal_image() where...
-
thomas.frobieter →
committed 25a0340d on 3.x authored by
Anybody →
- Status changed to Fixed
over 1 year ago 10:52am 8 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.