Add Status to OverviewTerms.php form

Think some simple test assertions would be good here.

Happy to continue chipping away at this, but I'm going to need some direction on where to add tests.

A logical place to test this might be https://git.drupalcode.org/project/drupal/-/blob/9f0d07d02cb7055f550fbe5...…]/tests/src/Functional/TaxonomyTermContentModerationTest.php… which doesn’t exist yet.

The way published/unpublished content is tested in https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/nod... isn’t really a UI test.

https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/tax... is only testing published terms. https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/tax... is testing unpublished functionality... but in Views.

https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/tax... gets into testing the admin/structure/taxonomy/manage/[vocabulary]

Does it make sense to add published and unpublished terms to test the new UI elements there?

missed adding the column in foreach ($current_page in the first patch

reordered the arrays to line up

Following up from our mini-chat in slack.

I think that adding a simple assertion to https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/tax... would be adequate for this. Rationality being that the published / unpublished status isn't dependent on content moderation being installed. Taxonomy terms have a status regardless, so surfacing it in the UI shouldn't hurt anything :-).

Maybe something like this added around #L386?

    // Check that the term is still present at admin UI after edit.
    $this->drupalGet('admin/structure/taxonomy/manage/' . $this->vocabulary->id() . '/overview');
    $this->assertSession()->pageTextContains($edit['name[0][value]']);
    $this->assertSession()->linkExists('Edit');

+  $term->setUnpublished()->save();

+  // Check that the term is now unpublished in the list.
+  $this->drupalGet('admin/structure/taxonomy/manage/' . $this->vocabulary->id() . '/overview');
+  $this->assertSession()->elementTextContains('css', "#edit-terms-tid{$term->id()}-status", 'Unpublished');

Added the test case as per #9 and raised an MR. Please review.

Added test caused a failure.

The variable $term is initialized at the first part of the function and after that, we made some updates to that term through UI, so the following code
$term->setUnpublished()->save();
is updating the term to the previous state and that is also causing failure to the tests after this, so that is why the code is updated like this

    // Unpublish the term.
    $this->drupalGet('taxonomy/term/' . $term->id() . '/edit');
    $this->submitForm(["status[value]" => 0], 'Save'); 

I have tested the MR and also run the PHP Unit Test.
Mr looks good to me. I think we can go with it.

Implementation Screenshot.

Unit test Screenshot.

Nice little improvement to this page, can't see anything to complain about so committed/pushed to 11.x (for release in 10.2.x), thanks!

Thank you to all of the collaborators on this contribution, especially @kreynen for leading the charge. This should be a great improvement for the code base.

Automatically closed - issue fixed for 2 weeks with no activity.