Fix access level on $offset of the views query plugin

Created on 9 May 2023, over 1 year ago

Updated 19 December 2023, 11 months ago

Problem/Motivation

Drupal 10 alpha7 introduced the $offset property to the QueryPluginBase as a public int property. (https://git.drupalcode.org/project/drupal/-/blob/10.0.0-alpha7/core/modu...)

That produces the following error:

Fatal error: Access level to Drupal\elasticsearch_connector_views\Plugin\views\query\ElasticsearchViewsQuery::$offset must be public (as in class Drupal\views\Plugin\views\query\QueryPluginBase) in /app/web/modules/contrib/elasticsearch_connector/modules/elasticsearch_connector_views/src/Plugin/views/query/ElasticsearchViewsQuery.php on line 26
1

Steps to reproduce

Enable the Elasticsearch Connector Views module.
Create a view selecting a elastic search index.
The error should appear when saving the view.

Proposed resolution

Modify ElasticsearchViewsQuery.php to support the changes introduced by the Drupal Core.

🐛 Bug report

Status

Needs review

Version

7.0

Component

Code

Created by

🇨🇴Colombia jidrone

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @jidrone
@jidrone opened merge request.
Status changed to Needs review over 1 year ago2:03am 9 May 2023
Comment over 1 year ago →
🇨🇴Colombia jidrone
Create MR and moved to Needs Review.
Comment 11 months ago →
🇦🇷Argentina lucasvm
This issue is still present on Drupal 10.
Comment 11 months ago →
🇳🇿New Zealand murrow
Just confirming that #3 works for me also (using Drupal 10.1.7).

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024