phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/pwa_firebase/
FILE: /var/www/html/contribution/web/modules/contrib/pwa_firebase/readme.md
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------
2 | WARNING | Line exceeds 80 characters; contains 102 characters
3 | WARNING | Line exceeds 80 characters; contains 121 characters
4 | WARNING | Line exceeds 80 characters; contains 90 characters
5 | WARNING | Line exceeds 80 characters; contains 114 characters
6 | WARNING | Line exceeds 80 characters; contains 117 characters
7 | WARNING | Line exceeds 80 characters; contains 124 characters
10 | WARNING | Line exceeds 80 characters; contains 87 characters
---------------------------------------------------------------------------
FILE: /var/www/html/contribution/web/modules/contrib/pwa_firebase/src/Form/PwaFirebaseConfigForm.php
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
224 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------
FILE: /var/www/html/contribution/web/modules/contrib/pwa_firebase/pwa_firebase.install
--------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
39 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------
FILE: /var/www/html/contribution/web/modules/contrib/pwa_firebase/pwa_firebase.module
--------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
8 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
20 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
22 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
35 | WARNING | [ ] Hook implementations should not duplicate @param documentation
35 | ERROR | [ ] Missing parameter comment
37 | WARNING | [ ] Hook implementations should not duplicate @return documentation
37 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/contribution/web/modules/contrib/pwa_firebase/pwa_firebase.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/contribution/web/modules/contrib/pwa_firebase/pwa_firebase.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------
25 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
33 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
41 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------
Fixed
2.0
Code
It involves compliance with, or the content of coding standards. Requires broad community agreement.
Every thing is fine except
* Implements hook_help().
function pwa_firebase_help
i think it will create alot of warning
Automatically closed - issue fixed for 2 weeks with no activity.