Uncomment override of settings.local.php as default

Created on 6 May 2023, over 1 year ago

Updated 7 May 2023, over 1 year ago

Problem/Motivation

Currently default.settings.php allows for use of a settings.local.php - but this code is commented and expectation is, once the site is installed someone will tweak the settings.php file to uncomment these lines if required.

#
# if (file_exists($app_root . '/' . $site_path . '/settings.local.php')) {
# include $app_root . '/' . $site_path . '/settings.local.php';
# }

In some workflows for eg. the docker workflow where we mount a settings.local.php file will not work by default unless the settings file is first modified.

Proposed resolution

If the settings.local.php file is present it should override settings, as such the lines should not be commented as the code is conditional anyways.

✨ Feature request

Status

Closed: duplicate

Version

10.0 ✨

Component

Configuration →

Last updated 1 day ago

Maintained by
🇬🇧United Kingdom @alexpott
🇺🇸United States @tim.plunkett

Created by

🇬🇧United Kingdom nidash

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @nidash
Comment over 1 year ago →
🇬🇧United Kingdom nidash
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
@nidash opened merge request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
28,458 pass, 1 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Custom Commands Failed
Status changed to Closed: duplicate over 1 year ago10:38am 7 May 2023
Comment over 1 year ago →
🇦🇺Australia dpi Perth, Australia
Duplicate of ✨ Uncomment the inclusion of the local setting file Closed: works as designed

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024