- Issue created by @Grevil
- last update
over 1 year ago 82 pass - @grevil opened merge request.
- Status changed to Needs review
over 1 year ago 12:35pm 12 May 2023 - 🇩🇪Germany Grevil
- I needed to overhaul the Settings Form a bit, here are the changes:
- Removed numeric value validation -> Use 'number' form type instead of 'textfield' for automatic validation instead.
- Removed empty value field validation -> Make the value fields required through states api, as soon as the relevant checkbox is checked.
- Change value fields schema from "string" to "integer" with an appropriate update hook added
- Outsource duplicate config code in its own "setConfigFromForm()" method
Please review!
I also tested it manually.
- Status changed to RTBC
over 1 year ago 12:56pm 12 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
Quite large changes, but tests are passing and this LGTM. Let's merge it.
- last update
over 1 year ago 82 pass - Status changed to Fixed
over 1 year ago 12:57pm 12 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.