- Issue created by @the_g_bomb
- Assigned to i-trokhanenko
- Issue was unassigned.
- πΊπ¦Ukraine i-trokhanenko Lutsk πΊπ¦
I think we should leave everything as it is. Most modules use configs to store private keys, passwords, etc. The Site Guardian hash can be easily overwritten in settings.php if needed.
For example, the Stripe module uses the same way to store public/private API keys, see below.
https://git.drupalcode.org/project/stripe/-/blob/8.x-1.x/config/install/...As an alternative solution, we can use the Drupal State APi β if we don't want to share the same hash between different site environments (dev/stage/prod).
Let me know what do you think. Thanks!
- Assigned to the_g_bomb
- Status changed to Needs review
over 1 year ago 3:04pm 31 May 2023 Thanks so much for this useful input @i-trokhanenko - I would tend to agree, but we can discuss further first if you like @the_g_bomb.
- π¬π§United Kingdom the_g_bomb
I agree that we should leave it as it.
If we want to update the README to highlight things, we could add something like;## Configuration management When exporting the site configuration, the site_guardian_key will be included in the config file with everything else. This is not unusual, as most modules use the configs to store private keys, passwords, etc., but there are any number of reasons why you may not wish to store the exported value and there are several ways to avoid this. You may try overwriting the value in the settings.php for example. You could also consider the [State API](https://www.drupal.org/docs/8/api/state-api/overviewduckduckgo.com) or perhaps even the [Config ignore module](https://www.drupal.org/project/config_ignore) to help with this.
- Status changed to RTBC
over 1 year ago 1:50pm 21 June 2023 - πΊπ¦Ukraine i-trokhanenko Lutsk πΊπ¦
That makes sense to me, let's add notes from the #5 comment to the README. Thank you @the_g_bomb
- @the_g_bomb opened merge request.
- Status changed to Fixed
over 1 year ago 12:48pm 14 July 2023 - π¬π§United Kingdom the_g_bomb
Merged. Perhaps we should update the project page with the new info included in the README, now.
Automatically closed - issue fixed for 2 weeks with no activity.