- Issue created by @tim-diels
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:22am 5 May 2023 - π§πͺBelgium tim-diels Belgium π§πͺ
Provided default schema to make labels translatable. A follow up issue can be added to provide a correct schema for all settings.
- Status changed to RTBC
about 1 year ago 11:31am 13 November 2023 - π§πͺBelgium borisson_ Mechelen, π§πͺ
While this is correct, and it does make the configuration translatable, it is only because the views_block config schema is configured like this:
views_block: type: block_settings label: 'View block' mapping: views_label: type: label label: 'Title' items_per_page: type: string label: 'Items per block'
Actually, because of all the core config schema validation stuff that his happening lately this is a good way to do it, because it will automatically get all the improvements from core.
I started out this comment by wanting to have this explicitly configured here, but I think the solution by @tim-diels actually makes a lot of sense, because it builds on existing schema configuration.Looks good to me.
- πͺπΈSpain Mecmecker
Tested and works for me on Drupal 10 php version 8.1.12
What provided by @tim-diels in #3 π Make configuration translatable RTBC looks good to me as well.
The schema for the module is working and making it translatable in Drupal version 10.1.7 and PHP v8.1.26
- πͺπΈSpain AntonioDP
For mi works well #3 π Make configuration translatable RTBC with drupal 10.1.5 and PHP 8.1.20.
Thanks The fork provided by Tim makes the block translatable.
- πͺπΈSpain manuel.adan π
manuel.adan β made their first commit to this issueβs fork.
- Status changed to Needs review
11 months ago 4:02pm 14 December 2023 - πͺπΈSpain manuel.adan π
I added the full schema on top of the existing changes, keeping the idea of extending core views block schema.
- π§πͺBelgium tim-diels Belgium π§πͺ
Actually there was a follow up issue π Provide full schema Postponed to build further on this.
- Status changed to RTBC
11 months ago 5:13pm 14 December 2023 The completed schema has been checked and seems to work.
Using the config_inspector module there was 6 errors before applying the patch and after applying the new schema the config_inspector report indicates that everything is fine.
-
manuel.adan β
committed 0fd371cc on 1.0.x authored by
tim-diels β
Issue #3358430 by tim-diels, manuel.adan, GuillemSM, Mecmecker,...
-
manuel.adan β
committed 0fd371cc on 1.0.x authored by
tim-diels β
- Status changed to Fixed
11 months ago 5:33pm 14 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.