hook_uninstall may not be required

Open on Drupal.org →

Created on 5 May 2023, over 1 year ago

Updated 19 May 2023, over 1 year ago

Problem/Motivation

Investigate config factory which may already remove a modules config by default, so hook_uninstall may be extraneous.

Steps to reproduce

Install the module.
Uninstall the module.

Proposed resolution

Remove the hook_uninstall.
Install the module.
Uninstall the module.
Check if the module config has been remove by the config factory.

Remaining tasks

Commit the required changes

User interface changes

None

API changes

None

Data model changes

None

✨ Feature request

Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom the_g_bomb

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Issue created by @the_g_bomb
Status changed to Needs review over 1 year ago1:53pm 5 May 2023
Comment over 1 year ago →
🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦
The site_guardian.settings automatically removes during module installation. I've removed the hook_uninstall. Please review patch #2.
Comment over 1 year ago →
🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦
Comment over 1 year ago →
🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦
Comment over 1 year ago →
🇬🇧United Kingdom the_g_bomb
The patch looks good to me. Will investigate further when I get time.
Assigned to seeduardo
Comment over 1 year ago →
🇬🇧United Kingdom the_g_bomb
Issue was unassigned.
Status changed to Fixed over 1 year ago4:19pm 19 May 2023
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024