Fix the issues reported by phpcs.

Created on 5 May 2023, about 1 year ago

Problem/Motivation

Found this issues reported by phpcs:

FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/admin_dialogs/admin_dialogs.module
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/admin_dialogs/admin_dialogs.info.yml
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
---------------------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/admin_dialogs/src/Entity/Form/AdminDialogEditForm.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 7 WARNINGS AFFECTING 11 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
20 | ERROR | [ ] Missing short description in doc comment
165 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
182 | ERROR | [ ] The array declaration extends to column 109 (the limit is 80). The array content should be split up over multiple lines
202 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
224 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
235 | ERROR | [ ] join() is a function name alias, use implode() instead
241 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
257 | ERROR | [x] Expected 1 space after "=>"; 2 found
257 | ERROR | [x] Expected 1 space after comma in argument list; 2 found
257 | ERROR | [x] Expected one space after the comma, 2 found
260 | WARNING | [x] A comma should follow the last multiline array item. Found: )
301 | WARNING | [x] A comma should follow the last multiline array item. Found: )
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/admin_dialogs/src/Entity/Form/AdminDialogGroupEditForm.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [ ] Missing short description in doc comment
54 | ERROR | [x] Expected 1 space after "=>"; 2 found
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/admin_dialogs/src/Controller/AdminDialogListBuilder.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
24 | ERROR | Missing member variable doc comment
----------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/admin_dialogs/src/AdminDialogsModule.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 4 WARNINGS AFFECTING 15 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
10 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
31 | ERROR | [x] Whitespace found at end of line
56 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
64 | ERROR | [ ] Public method name "AdminDialogsModule::form_alter" is not in lowerCamel format
66 | WARNING | [ ] Unused variable $entity.
77 | ERROR | [ ] The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
88 | ERROR | [ ] Public method name "AdminDialogsModule::entity_operation_alter" is not in lowerCamel format
89 | ERROR | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines
110 | ERROR | [x] Space found before object operator
110 | ERROR | [ ] The array declaration extends to column 119 (the limit is 80). The array content should be split up over multiple lines
124 | ERROR | [ ] Public method name "AdminDialogsModule::menu_local_tasks_alter" is not in lowerCamel format
125 | ERROR | [x] Space found before object operator
125 | ERROR | [ ] The array declaration extends to column 121 (the limit is 80). The array content should be split up over multiple lines
147 | ERROR | [ ] Public method name "AdminDialogsModule::menu_local_actions_alter" is not in lowerCamel format
148 | ERROR | [x] Space found before object operator
148 | ERROR | [ ] The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines
174 | ERROR | [ ] Public method name "AdminDialogsModule::entity_type_build" is not in lowerCamel format
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

Time: 618ms; Memory: 12MB

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml admin_dialogs/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Closed: works as designed

Version

1.0

Component

Code

Created by

πŸ‡΅πŸ‡­Philippines kenyoOwen

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @kenyoOwen
  • Issue was unassigned.
  • Status changed to Closed: works as designed about 1 year ago
  • πŸ‡΅πŸ‡­Philippines kenyoOwen

    Hi minnur

    I'm sorry for this I'm new to creating an issue and a merge request and using the git, I think I made a mistake when I create a fork. I'm still studying how to use it.

    Thank you,
    Ken

Production build 0.69.0 2024