Set retry enabled to FALSE in config settings has no effect

Hm yes I can see how array_filter causes an issue here. However we can't just remove it because because NULLs in the default config will inadvertently override defaults in the client. We need a solution here booleans but filters NULLs, I think?

Yes, you are right. I will provide a solution.

I have added a function to filter just null values.

Shorthand function added.

Then I need help. My phpcs is clean with official Drupal profile.

Let us save time and effort, so I propose, that you resolve this open thread.

@danielspeicher you may want to inspect your phpcs config. Here is the output from your branch:

~/PhpstormProjects/http_client_retry 3358215-set-retry-enabled > vendor/bin/phpcs                                 
.................E. 19 / 19 (100%)

FILE: src/Http/HttpClientMiddleware.php
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 78 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

Time: 2.52 secs; Memory: 14MB

Anyway yeah I'll put in a quick fix for this before merge. Thank you!

Thank you very much. I will check our config.

Automatically closed - issue fixed for 2 weeks with no activity.