Coding standards

FILE: ...sr/local/config_normalizer/src/ConfigItemNormalizerInterface.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 21 | WARNING | Line exceeds 80 characters; contains 85 | | characters (Drupal.Files.LineLength.TooLong) ---------------------------------------------------------------------- FILE: ...fig_normalizer/src/Config/NormalizedReadOnlyStorageInterface.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement | | (Drupal.Classes.UnusedUseStatement.UnusedUse) 6 | WARNING | [x] Unused use statement | | (Drupal.Classes.UnusedUseStatement.UnusedUse) 7 | WARNING | [x] Unused use statement | | (Drupal.Classes.UnusedUseStatement.UnusedUse) 59 | ERROR | [ ] Missing parameter name | | (Drupal.Commenting.FunctionComment.MissingParamName) 70 | WARNING | [ ] Line exceeds 80 characters; contains 85 | | characters (Drupal.Files.LineLength.TooLong) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: .../config_normalizer/src/Config/NormalizedStorageComparerTrait.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 44 | ERROR | [x] Expected "\Drupal\Core\Config\StorageComparer" but | | found "\Drupal\Core\Config\StorageComparer;" for | | function return type | | (Drupal.Commenting.FunctionComment.InvalidReturn) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...ormalizer/src/Plugin/ConfigNormalizer/ConfigNormalizerActive.php ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 32 | ERROR | [ ] The array declaration extends to column 102 (the | | limit is 80). The array content should be split up | | over multiple lines | | (Drupal.Arrays.Array.LongLineDeclaration) 34 | ERROR | [x] Expected 1 blank line after function; 0 found | | (Squiz.WhiteSpace.FunctionSpacing.AfterLast) 35 | ERROR | [x] The closing brace for the class must have an empty | | line before it | | (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...zer/src/Plugin/ConfigNormalizer/ConfigNormalizerFilterFormat.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 6 | WARNING | [x] Unused use statement | | (Drupal.Classes.UnusedUseStatement.UnusedUse) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: /usr/local/config_normalizer/src/ConfigItemNormalizer.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 41 | ERROR | The array declaration extends to column 86 (the limit | | is 80). The array content should be split up over | | multiple lines | | (Drupal.Arrays.Array.LongLineDeclaration) 65 | ERROR | Description for the @return value is missing | | (Drupal.Commenting.FunctionComment.MissingReturnComment) ---------------------------------------------------------------------- Time: 192ms; Memory: 10MB

Comments & Activities

Issue created by @joegraduate
Issue was unassigned.
Status changed to Needs review almost 2 years ago1:26am 3 May 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
Build Successful
Comment almost 2 years ago →
🇺🇸United States joegraduate Arizona, USA
Comment almost 2 years ago →
System Message
The last submitted patch, 2: 3357774-2.patch, failed testing. View results →
Comment almost 2 years ago →
🇺🇸United States joegraduate Arizona, USA
No actual tests exist yet. Coding standards messages are resolved with patch.
Status changed to RTBC almost 2 years ago4:14am 3 May 2023
Comment almost 2 years ago →
🇵🇭Philippines paraderojether
Hi joegraduate

I reviewed patch #@, and verified it resolved all the errors and warnings reported by phpcs. Drupal core version 9.5.8, Configuration Normalizer 8.x-1.x-dev.

I added screenshots for reference.
Thank You.
Comment almost 2 years ago →
🇺🇸United States joegraduate Arizona, USA
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
1 pass
Comment almost 2 years ago →
System Message

joegraduate → authored e0213134 on 8.x-1.x
Issue #3357774 by joegraduate, paraderojether: Coding standards
Status changed to Fixed almost 2 years ago7:40pm 3 May 2023
Comment almost 2 years ago →
🇺🇸United States joegraduate Arizona, USA
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities