- Issue created by @ergonlogic
- last update
almost 2 years ago Composer require failure - @ergonlogic opened merge request.
-
ergonlogic →
committed b26057a4 on 1.0.x
Issue #3357741: Make config enforcement during cache-rebuild optional
-
ergonlogic →
committed b26057a4 on 1.0.x
- Status changed to Fixed
almost 2 years ago 6:04am 5 May 2023 - Status changed to Needs work
almost 2 years ago 1:12am 8 May 2023 - 🇨🇦Canada ambient.impact Toronto
I hate to be a wet blanket, but this broke our tests because the testbot (rightfully) can't find the
use Drush\Drush;
added inconfig_enforce.module
, because it's not listed in ourcomposer.json
dependencies - nor should it be listed since we only provide an optional Drush command that the module works perfectly fine without.Is there a reason we even need to explicitly call
Drush::logger()
? Outside of the Drush command, this module shouldn't need to know about or care about the existence of Drush; at least, that's how I look at it. If the problem that it's solving is to show output from running the enforcement, might it not be better to see if it's possible to somehow get the log messages from our logger channel that were generated between before we do the enforce and after it's done, or something like that? After a bit of digging, it looks like Drush even provides a service that sounds like it might be for what we're trying to do. - 🇨🇦Canada ergonlogic Montréal, Québec 🇨🇦
I missed the dependency on Drush in ✨ Import configs when modules are enabled Active . Fixed in latest commit and marked as "Needs review" to re-test.
- Status changed to Fixed
almost 2 years ago 4:07am 12 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.