Provide Drush command to enforce configs

Isn't 'needs review' the way to get tests to run?

I think it's primarily now when a merge request is marked as ready. They also run again if additional commits are added to the merge request. That said, GitLab seems to think there aren't any changes in merge request 22, which is weird.

All that was needed here was to bump the Drush bootstrap level, so that the Drupal logger could take effect. That allowed be to remove the explicit call to Drush::logger().

However, Behat tests are now broken, so I'll try to figure that out.

8b8a5944 - Moved 'ce_test_drush_command' module to tests/modules

Drush can't seem to enable modules under tests/modules

All that was needed here was to bump the Drush bootstrap level, so that the Drupal logger could take effect. That allowed be to remove the explicit call to Drush::logger().

Actually, I was wrong here. The problem is that drush cr doesn't appear to allow us to log to Drush output using \Drupal::logger(). That said,, our logging still shows up in the watchdog log, so I can check there in the tests.

So I did a bit of digging as to why Drush can't seem to enable modules under the tests/modules path, and it looks like it's due to Drupal core excluding those from discovery by default. Basically, you have to uncomment $settings['extension_discovery_scan_tests'] = true; in your settings.local.php before doing drush pm:install - I've tested this locally and Drush does indeed now install modules from tests/modules once the setting is enabled. Is there a way to specify this stuff in Behat? Because if so, it might be a one liner and would allow the test module to live under tests/modules to keep things tidy.

Whoops.

As for the logging stuff, I reached out on the Drupal.org Slack and was pointed to the fact that Drush now supports adding custom loggers so that would be one way we could output stuff to console. Another way would be to add a hook to the Drush cache rebuild command and output our console messages that way. Either way, I'll open a follow up to not block this issue being merged.

As for the logging stuff, I reached out on the Drupal.org Slack and was pointed to the fact that Drush now supports adding custom loggers so that would be one way we could output stuff to console. Another way would be to add a hook to the Drush cache rebuild command and output our console messages that way. Either way, I'll open a follow up to not block this issue being merged.

In config-enforce-localdev, I committed our settings file, and added the bit that allows Drush to find modules under test dirs. This worked, and so I've also moved the test module here back where it belongs.

Let's follow up on the logging in ✨ Provide Drush command output when enforcing configuration via cache rebuild Active .

Since tests are now all passing, despite DrupalCI wierdness, I'm going to merge this branch, close the MRs and this ticket.

Is it alright if I remove the now unused use Drush\Drush; in config_enforce.module and remove the explicit dependency on Drush from the composer.json?

I guess Drugs isn't strictly required. Maybe move it to suggest.

Sure, let me throw that together quickly.

And it's done! 🥳

Automatically closed - issue fixed for 2 weeks with no activity.