- Issue created by @sujan.shrestha
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- Status changed to Needs work
over 1 year ago 9:03am 2 May 2023 - 🇮🇳India vishal.kadam Mumbai
@sujan shrestha Please specify which module you want us to review.
Hi @vishal.kadam, Thank you for the information. I have created a Timeline Block module. Please check here https://www.drupal.org/project/timeline_block → .
- Status changed to Needs review
over 1 year ago 9:51am 2 May 2023 - Status changed to Needs work
over 1 year ago 9:59am 2 May 2023 - 🇮🇳India vishal.kadam Mumbai
1.
masteris a wrong branch name, as branch names end with the literal .x. That branch needs to be removed.2. Fix phpcs issues. You can use the PHPCS tool for checking and resolving issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml timeline_block/ FILE: timeline_block/css/timeline.css ------------------------------------------------------------------------------ FOUND 6 ERRORS AFFECTING 5 LINES ------------------------------------------------------------------------------ 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [ ] No style definition found on line; check for missing colon 523 | ERROR | [x] Selectors must be on a single line 524 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 627 | ERROR | [ ] Class definition is empty 653 | ERROR | [ ] Class definition is empty ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ FILE: timeline_block/src/Plugin/Block/TimelineBlock.php -------------------------------------------------------------------------------- FOUND 37 ERRORS AND 16 WARNINGS AFFECTING 51 LINES -------------------------------------------------------------------------------- 7 | WARNING | [x] Unused use statement 19 | ERROR | [x] Opening brace should be on the same line as the declaration 25 | ERROR | [x] Opening brace should be on the same line as the declaration 37 | ERROR | [x] Opening brace should be on the same line as the declaration 49 | ERROR | [x] Short array syntax must be used to define arrays 69 | ERROR | [x] Expected newline after closing brace 85 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 85 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 119 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 158 | ERROR | [x] Short array syntax must be used to define arrays 159 | WARNING | [ ] #options values usually have to run through t() for translation 160 | WARNING | [ ] #options values usually have to run through t() for translation 161 | WARNING | [ ] #options values usually have to run through t() for translation 162 | WARNING | [ ] #options values usually have to run through t() for translation 163 | WARNING | [ ] #options values usually have to run through t() for translation 164 | WARNING | [ ] #options values usually have to run through t() for translation 165 | WARNING | [ ] #options values usually have to run through t() for translation 166 | WARNING | [ ] #options values usually have to run through t() for translation 167 | WARNING | [ ] #options values usually have to run through t() for translation 168 | WARNING | [ ] #options values usually have to run through t() for translation 182 | ERROR | [x] Opening brace should be on the same line as the declaration 191 | ERROR | [ ] Missing short description in doc comment 192 | ERROR | [ ] Missing parameter comment 193 | ERROR | [ ] Missing parameter comment 196 | ERROR | [x] Opening brace should be on the same line as the declaration 203 | ERROR | [ ] Missing short description in doc comment 204 | ERROR | [ ] Missing parameter comment 205 | ERROR | [ ] Missing parameter comment 206 | ERROR | [ ] Description for the @return value is missing 209 | ERROR | [x] Opening brace should be on the same line as the declaration 215 | ERROR | [ ] Missing short description in doc comment 216 | ERROR | [ ] Missing parameter comment 217 | ERROR | [ ] Missing parameter comment 220 | ERROR | [x] Opening brace should be on the same line as the declaration 227 | ERROR | [x] Expected 1 blank line after function; 0 found 228 | ERROR | [ ] Missing short description in doc comment 229 | ERROR | [ ] Missing parameter comment 230 | ERROR | [ ] Missing parameter comment 233 | ERROR | [x] Opening brace should be on the same line as the declaration 246 | ERROR | [x] Opening brace should be on the same line as the declaration 250 | ERROR | [x] Short array syntax must be used to define arrays 251 | ERROR | [x] Short array syntax must be used to define arrays 252 | ERROR | [x] Short array syntax must be used to define arrays 270 | ERROR | [x] Expected newline after closing brace 290 | ERROR | [x] Expected newline after closing brace 311 | ERROR | [x] Inline comments must start with a capital letter 311 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 316 | WARNING | [ ] File::load calls should be avoided in classes, use dependency injection instead 327 | ERROR | [x] Opening brace should be on the same line as the declaration 328 | WARNING | [ ] Unused variable $config. 332 | ERROR | [x] Short array syntax must be used to define arrays 336 | ERROR | [x] Short array syntax must be used to define arrays 345 | WARNING | [x] A comma should follow the last multiline array item. Found: $timeline_header -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 25 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: timeline_block/timeline_block.libraries.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 5 | ERROR | [x] Expected 1 newline at end of file; 3 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: timeline_block/timeline_block.module -------------------------------------------------------------------------------- FOUND 52 ERRORS AND 5 WARNINGS AFFECTING 34 LINES -------------------------------------------------------------------------------- 16 | ERROR | [x] Opening brace should be on the same line as the declaration 33 | ERROR | [x] Opening brace should be on the same line as the declaration 40 | WARNING | [x] A comma should follow the last multiline array item. Found: NULL 41 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 42 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 47 | ERROR | [x] Doc comment short description must end with a full stop 48 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 48 | ERROR | [ ] Missing parameter comment 48 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 49 | ERROR | [x] Separate the @param and @return sections by a blank line. 49 | ERROR | [ ] Description for the @return value is missing 51 | ERROR | [ ] Type hint "[type]" missing for $timeline_data_config 51 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "get_timeline_description_images" but expected | | "timeline_block_get_timeline_description_images" 52 | ERROR | [x] Opening brace should be on the same line as the declaration 53 | ERROR | [x] Short array syntax must be used to define arrays 56 | WARNING | [ ] Unused variable $key. 68 | ERROR | [x] Doc comment short description must start with a capital letter 69 | ERROR | [ ] Doc comment short description must end with a full stop 69 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 70 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 70 | ERROR | [ ] Missing parameter comment 70 | ERROR | [x] Expected 1 spaces after parameter type; 13 found 70 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 71 | ERROR | [ ] Missing parameter comment 71 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 71 | ERROR | [x] Data types in @param tags need to be fully namespaced 72 | ERROR | [x] Separate the @param and @return sections by a blank line. 72 | ERROR | [ ] @return doc comment specified, but function has no return statement 72 | ERROR | [ ] Description for the @return value is missing 74 | ERROR | [ ] Type hint "[type]" missing for &$form 75 | ERROR | [x] Opening brace should be on the same line as the declaration 80 | ERROR | [x] Inline comments must start with a capital letter 80 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 85 | ERROR | [x] Inline comments must start with a capital letter 85 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 116 | ERROR | [x] Doc comment short description must start with a capital letter 117 | ERROR | [ ] Doc comment short description must end with a full stop 117 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 118 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 118 | ERROR | [ ] Missing parameter comment 118 | ERROR | [x] Expected 1 spaces after parameter type; 13 found 118 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 119 | ERROR | [ ] Missing parameter comment 119 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 119 | ERROR | [x] Data types in @param tags need to be fully namespaced 120 | ERROR | [x] Separate the @param and @return sections by a blank line. 120 | ERROR | [ ] @return doc comment specified, but function has no return statement 120 | ERROR | [ ] Description for the @return value is missing 122 | ERROR | [ ] Type hint "[type]" missing for $form 123 | ERROR | [x] Opening brace should be on the same line as the declaration 128 | WARNING | [ ] Unused variable $key. 137 | ERROR | [ ] Missing short description in doc comment 138 | ERROR | [ ] Missing parameter comment 138 | ERROR | [ ] Missing parameter type 141 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "get_timeline_editor_files" but expected | | "timeline_block_get_timeline_editor_files" 142 | ERROR | [x] Opening brace should be on the same line as the declaration 157 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 33 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- - 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for applying!
The issue summary needs to describe the project used for the application. - Status changed to Closed: won't fix
7 months ago 6:35pm 6 March 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.