- Issue created by @tadean
- Assigned to tadean
- Status changed to Needs work
over 1 year ago 12:17am 3 May 2023 - πΊπΈUnited States joegraduate Arizona, USA
The attached patch adds a basic test that fails because of this issue.
- last update
over 1 year ago 1 fail - Status changed to Needs review
over 1 year ago 3:58pm 3 May 2023 - Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass This patch refactors
isActiveStorageContext()
to make use ofDrupal\Component\DependencyInjection\ReverseContainer
for reverse lookup of the storage service. Since this branch is currently cites compatibility with D9 in general, I have attempted to make the change backwards compatible, with the following approaches:- In 9.5.1+,
ReverseContainer
will be used - In 9.5.0, as
ReverseContainer
does not exist,getServiceIdMapping()
will be used - in 9.4 and below, it will fall back on the previous approach of the
_serviceId
property
At the point when only 9.5.1+ compatibility is needed, I think these deprecated fallbacks should probably be removed.
The patch includes the new test from @joegraduate thanks!
In my testing with 9.4.15, 9.5.0, and 9.5.1+ this seems to fix the original broken config_sync β test ( π Address 3.0.x-dev test failures since Drupal 9.5.x Fixed ) that revealed this issue.
- In 9.5.1+,
- Status changed to RTBC
over 1 year ago 5:45pm 3 May 2023 - πΊπΈUnited States joegraduate Arizona, USA
#4 looks great to me. I think we should commit this and create a new release that includes this change. Thanks @tadean for coming up with such a thorough backwards-compatible fix for this issue!
-
tadean β
authored 288424a3 on 8.x-1.x
Issue #3357495 by joegraduate, tadean: isActiveStorageContext() fails in...
-
tadean β
authored 288424a3 on 8.x-1.x
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 6:40pm 3 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.