Remove bugfix for PHP bug 48383

Removing the bugfix.

Here are some patches that all contain the test, but using different scenarios for the bugfix solution.

The last submitted patch, 3: 3357454-3-removed-bugfix.patch, failed testing. View results →

The last submitted patch, 3: 3357454-3-just-tests.patch, failed testing. View results →

The last submitted patch, 3: 3357454-3-removed-bugfix-with-insert-fix.patch, failed testing. View results →

The last submitted patch, 3: 3357454-3-working.patch, failed testing. View results →

As all tests fail for the other databases, we should not use this fix.

Here is a updated patch which removes this fix and adjust the test to expect the exception. and assert that there are no rows added to the table.

Seems didn't pass all the databases.

Did not manually test so leaving that tag.

I've adjusted the test a bit. The test failed on SQLite because it doesn't use strict mode on the tables. I've created a new issue regarding this and referred to it in a todo. The issue can be found here 🐛 Use strict table with SQLite 3.37 and above Active

#11 seems to pass all databases. Think this is good for committer review.

The test coverage looks correct to me, so removing the tag.

Committed and pushed b78ae9ef49 to 11.x. Thanks!

This is a cleanup of harmless code and flagged as a task, so I don't think it's worth backporting.

1. +++ b/core/tests/Drupal/KernelTests/Core/Database/InsertTest.php
   @@ -232,4 +233,66 @@ public function testInsertIntegrityViolation() {
   +    if ($this->connection->databaseType() == 'sqlite') {
   +      $this->markTestSkipped('SQLite does not use strict tables.');
   +    }
   

   This is hardcoding a database type check. Should have used a test extending from DriverSpecificKernelTestBase or DriverSpecificDatabaseTestBase instead.

2. +++ b/core/tests/Drupal/KernelTests/Core/Database/InsertTest.php
   @@ -232,4 +233,66 @@ public function testInsertIntegrityViolation() {
   +    $this->expectException(DatabaseExceptionWrapper::class);
   +    $this->connection->insert('insert_bool')
   +      ->fields(['id' => 1, 'test_field_1' => FALSE])
   +      ->execute();
   +
   +    // We should not have any rows in this table.
   +    $this->assertEquals(0, $this->connection->select('insert_bool')->countQuery()->execute()->fetchField());
   

   The assertEquals will never execute here, if the insert is expected to throw the exception - expectException will not return execution to the test once it captures the exception thrown.

I suggest to revert this to get it fixed.

Reverted.

+++ b/core/tests/Drupal/KernelTests/Core/Database/InsertTest.php
@@ -232,4 +233,66 @@ public function testInsertIntegrityViolation() {
+    $this->connection->query('INSERT INTO {insert_bool} (id,test_field_1) VALUES (:id, :test_field_1)', [':id' => 1, ':test_field_1' => FALSE]);

Also, the field identifiers should be enclosed in square brackets i.e. INSERT INTO {insert_bool} ([id],[test_field_1]) VALUES ...