Flag a warning during status check if the OpenSSL extension is not enabled

👍

I think we should probably make a validator for this rather that using hook_requirements. If the message is only from hook_requirements say if you installed project browser and you didn't go to the status report page but rather just went to the form to install modules you won't see the message, right?

I think the hook_requirements suggestion does bring up the point that if you install package_manager and not automatic_updates then you are not going to see any of our messages from our validators on the status report page.

I think our original thinking is that automatic_updates is the only use case we have right now that does automated operations without a user present so we want to warn the user ahead of time.

In the use cases where a module makes a UI to perform Composer operations it should also fire the status check event and display all the results on that UI.

But I think this issue does bring up the point that seeing the validator messages on the status report maybe be valuable even if you aren't using automatic updates. But I think still with automatic_udpates it is more critical because you might be depending on it to apply security updates. It is not as important ahead of time for you to know that you might have problem installing a new module.

I think it makes sense as a validator, but if the current (and possibly permanent) behaviour is to require SSL wouldn't it be REQUIREMENTS_ERROR rather than warning and prevent install altogether? You could still end up with a site migrated to a server/dev environment with no open_ssl extension too so worthwhile being a validator either way.

ok. here is what I think we should do about the general problem that you don't see any package_manager status check validator errors on the status report page if Automatic Updates is not installed. I can a follow-up issue for this

1. in package_manager_requirements we should fire StatusCheckEvent and display all the results in 1 requirements entry. We vary the message based on whether there are errors an/or warnings. This message would always be a REQUIRMENTS_WARNING because depending on what Package Manager is going to be use for it might not critical error that you can't use the module that depends on package manager

   Since StatusCheckEvent needs a stage object package_manager_requirements could just make anonymous class that extends StageBase. This we mean it will trigger all the validators that don't care what the stage object is. That includes all of the package_manager validators themselves and any custom/contrib validators that might be written that should apply to all stage instances.

2. Automatic Updates should implements hook_requirements_alter. It should probably just unset the package_manager entry and run the requirements like it does now in automatic_updates_requirements.

   This is important because \Drupal\automatic_updates\Validation\StatusChecker::run() uses and instance of UpdateStage or CronUpdateStage depending on whether cron updates are on.

   This will still trigger all the validators that don't care what type of stage instance it is, all the package_manager ones, in addition to the Automatic Updates specific ones that only apply to automatic updates, such as VersionPolicyValidator.

Created 📌 Warn about package_manager errors and warning on the status report page Needs work , still need to update the summary here

@phenaproxima the custom commands failed. I also ran the test locally but they failed

We need to make sure other test pass regardless of the developer php extensions.

see MR comments

Look good!

I like that adding validation for other php extensions in the future should be straight forward!

don't think this needs to be assigned to me. Thought maybe I was suppose to make a follow-up but I already made 📌 Warn about package_manager errors and warning on the status report page Needs work

Automatically closed - issue fixed for 2 weeks with no activity.