- Issue created by @InaW
- last update
over 1 year ago 1 pass The issue seems to be that
function dumpCmd($tableSelection): ?string {
in is nullable inGdprSqlMysql
.php but not inDrush\Sql\SqlMysql
I created a merge request to remove the nullable option: https://git.drupalcode.org/project/gdpr/-/merge_requests/26
- Status changed to Needs review
over 1 year ago 4:43am 16 June 2023 - 🇮🇳India rajeshreeputra Pune
changes looks good and agree that '?' is not needed here.
- Status changed to RTBC
about 1 year ago 10:02pm 20 December 2023 - 🇨🇭Switzerland yepa Geneva
Thanks folks for your work!
I encountered this error :
$ ddev drush gdpr-sql-dump > local/2023-12-20_prod_1.2.2_gdpr.sql PHP Fatal error: Declaration of Drupal\gdpr_dump\Sql\GdprSqlMysql::dumpCmd($tableSelection): ?string must be compatible with Drush\Sql\SqlMysql::dumpCmd($table_selection): string in web/modules/contrib/gdpr/modules/gdpr_dump/src/Sql/GdprSqlMysql.php on line 140 [warning] Drush command terminated abnormally. Failed to run drush gdpr-sql-dump: exit status 1
I review the code and it seems fine.
I've tested the patch attached with following versions and it works !
- drupal/gdpr 3.0.0
- drush/drush 11.3.2
- last update
about 1 year ago 1 pass - last update
about 1 year ago 1 pass -
Rajeshreeputra →
committed ad559483 on 3.0.x authored by
InaW →
Issue #3356798 by InaW, yepa, Nicoc, Rajeshreeputra: Drush 11: gdpr dump...
-
Rajeshreeputra →
committed ad559483 on 3.0.x authored by
InaW →
- Status changed to Fixed
about 1 year ago 12:56pm 22 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.