- Issue created by @paulocs
- Merge request !19Issue #3356738: Update the BlockClassTest class to work on 2.x branch → (Closed) created by paulocs
- Status changed to Needs review
over 1 year ago 12:25am 13 May 2023 - First commit to issue fork.
- Merge request !39Issue #3356738 by DYdave, paulocs: Updated module's phpunit test class to work with the 2.x branch. → (Merged) created by dydave
- Status changed to Fixed
6 months ago 12:44am 31 May 2024 - 🇫🇷France dydave
Thanks a lot @paulocs for the great help and work on this issue!
In the end, it was preferred to go with
oliveroinstead ofstable9(suggested in MR!33#3df28a9e in 📌 Add Gitlab CI Needs review ) orstark(suggested in this ticket's MR!19) since they don't add classes on markup.In this test, ideally, we'd like to confirm the classes added by other components don't get overridden/replaced.
So in other words: test that classes that were supposed to be added are still there after the block_class classes are added, see:
https://git.drupalcode.org/project/block_class/-/merge_requests/39/diffs...
In particular:class="TestClass_content block block-system block-system-main-block".Changes merged!
Thanks again!
Automatically closed - issue fixed for 2 weeks with no activity.