- Issue created by @Anybody
- First commit to issue fork.
- 🇩🇪Germany Grevil
I think the text should be in bold to be visible? Perhaps below the help text, before the "Reference type" selection?
This part could be difficult to implement, as we are hooking into the form from the outside. Adding the text at the front or the end of the "$form" isn't an issue, but if we want to add the info in the middle of the form, we need to slice the array first, insert our text and put the array back together.
I am unsure if this would be a wise idea 😅
- last update
about 2 years ago 18 pass - @grevil opened merge request.
- Status changed to Needs work
about 2 years ago 3:02pm 5 May 2023 - 🇩🇪Germany Grevil
OK, I couldn't finish this in time, but it is 99% implemented. The rest will come on Monday!
- last update
about 2 years ago 18 pass - Status changed to Needs review
about 2 years ago 7:45am 8 May 2023 - 🇩🇪Germany Grevil
Done! I removed the links, as they need to be dynamically tailored to the current field, which I find a bit unnecessary, as the page can simply be reached by clicking on the Tab.
- Assigned to Anybody
- Status changed to Needs work
about 2 years ago 8:43am 8 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thank you @Grevil, nice!
I'll add some minor fine-graded textual changes, then we're ready to merge this.
Did you check both cases (if / else) work as expected and the text only appears on entity reference fields?I think tests would be too heavy here, a simple check should be enought.
- 🇩🇪Germany Grevil
Oh forgot something, of course we need to make sure, that "$fieldStorage" is an instance of "FieldStorageConfig". If it is a base field, we do not have set / getThirdPartySettings defined!
I'll be right on it.
- last update
about 2 years ago 18 pass - last update
about 2 years ago 18 pass - Status changed to Needs review
about 2 years ago 9:43am 8 May 2023 - 🇩🇪Germany Grevil
Alright! Only need the textual change now, so it can be merged! ;)
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
about 2 years ago Not currently mergeable. - Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Please rebase and final review. I hope texts are as clear as possible now and I wanted to reuse the existing translation of the tab so they are
===
even if the translation changes ;) - last update
about 2 years ago 18 pass - last update
about 2 years ago 18 pass - Status changed to RTBC
about 2 years ago 7:09am 9 May 2023 - last update
about 2 years ago 18 pass - Issue was unassigned.
- Status changed to Fixed
about 2 years ago 7:14am 9 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.