- Issue created by @baldwinlouie
- last update
over 1 year ago 366 pass - @baldwinlouie opened merge request.
- Status changed to Needs review
over 1 year ago 3:53am 26 April 2023 - 🇺🇸United States baldwinlouie
@yas, this patch adds support for toggling the SPA on/off. Since we don't specify
drupal/simple_oauth
in the Cloud module'scomposer.json
anymore, I'm doing a check to make sure that module is available before toggling SPA on.The reason is that if
cloud_dashboard
is not enabled in an installation, I will enable it and setup the simple_oauth consumer. If drupal/simple_oauth is not available, we will encounter an error. This could happen if a user downloads cloud module without using the Cloud Orchestrator distribution. - Status changed to Needs work
over 1 year ago 5:17am 26 April 2023 - 🇺🇸United States yas California 🇺🇸
@baldwinlouie
Thank you for the patch. It looks good. I posted my comments. Thanks!
- last update
over 1 year ago 366 pass - Status changed to Needs review
over 1 year ago 5:08pm 26 April 2023 - last update
over 1 year ago 366 pass - Status changed to Needs work
over 1 year ago 8:26pm 26 April 2023 - 🇺🇸United States yas California 🇺🇸
@baldwinlouie
Thank you for the update. Can you please fix the coding standard error?
https://www.drupal.org/pift-ci-job/2652496 →
Thanks
- Status changed to Needs review
over 1 year ago 8:30pm 26 April 2023 - last update
over 1 year ago 366 pass - Status changed to RTBC
over 1 year ago 10:04pm 26 April 2023 - 🇺🇸United States yas California 🇺🇸
@baldwinlouie
Thank you for the update. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - last update
over 1 year ago 366 pass - last update
over 1 year ago 366 pass - last update
over 1 year ago 366 pass -
yas →
committed 59f2ca80 on 6.x authored by
baldwinlouie →
Issue #3356454 by baldwinlouie, yas: Add an option to turn on/off SPA...
-
yas →
committed 59f2ca80 on 6.x authored by
baldwinlouie →
-
yas →
committed c14c9e0d on 5.x authored by
baldwinlouie →
Issue #3356454 by baldwinlouie, yas: Add an option to turn on/off SPA...
-
yas →
committed c14c9e0d on 5.x authored by
baldwinlouie →
- Status changed to Fixed
over 1 year ago 10:09pm 26 April 2023 - Status changed to Needs work
over 1 year ago 10:30pm 26 April 2023 - 🇺🇸United States yas California 🇺🇸
@baldwinlouie
Sorry, I found the following coding standard violation. Can you please create a hotfix? Thanks!
FILE: ...web/modules/contrib/cloud/src/Form/Config/CloudAdminSettings.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 300 | WARNING | \Drupal calls should be avoided in classes, use | | dependency injection instead ----------------------------------------------------------------------
- last update
over 1 year ago 366 pass - @baldwinlouie opened merge request.
- Status changed to Needs review
over 1 year ago 10:59pm 26 April 2023 - 🇺🇸United States yas California 🇺🇸
@baldwinlouie
Thank you for the hotfix. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - Status changed to RTBC
over 1 year ago 11:32pm 26 April 2023 -
yas →
committed ca09215c on 6.x authored by
baldwinlouie →
Issue #3356454 by baldwinlouie, yas: Hotfix - Add an option to turn on/...
-
yas →
committed ca09215c on 6.x authored by
baldwinlouie →
-
yas →
committed 86b7b4d3 on 5.x authored by
baldwinlouie →
Issue #3356454 by baldwinlouie, yas: Hotfix - Add an option to turn on/...
-
yas →
committed 86b7b4d3 on 5.x authored by
baldwinlouie →
- Status changed to Fixed
over 1 year ago 11:34pm 26 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.