Missing MediaSource plugin definition attributes

Added missing attributes:

      'thumbnail_width_metadata_attribute' => 'thumbnail_width',
      'thumbnail_height_metadata_attribute' => 'thumbnail_height',

MR created.

Hmm.. tests pass on D9.5 but fail on D10. I don't see how that could be related to this MR, though

@szato - Can I get steps to reproduce the warning?

Below are the steps I followed:

1. Install Drupal 9.5.x (including Media Library) and oEmbed Providers 2.x-dev
2. For Media settings, check 'Standalone media URL'
3. Add a YouTube video (media/1)
4. View https://my-site/media/1
5. Check logs - no warnings

Tests are fixed in D10.1+: 🐛 Tests Failing at HEAD for D10 Fixed

The PHP warnings are:

Warning: Undefined array key "thumbnail_width_metadata_attribute" in Drupal\media\Entity\Media->getThumbnailWidth() (line 285 of core/modules/media/src/Entity/Media.php).
Warning: Undefined array key "thumbnail_height_metadata_attribute" in Drupal\media\Entity\Media->getThumbnailHeight() (line 310 of core/modules/media/src/Entity/Media.php).

Fix looks good to me. +1 RTBC

That's enough info. Drupal\media\Entity\Media is expecting those properties to be set. The two properties were added at some point after this module was released.

@bwaindwain - I missed crediting you on the original merge, so I pushed an empty commit to grant credit.

Automatically closed - issue fixed for 2 weeks with no activity.

I can confirm that the changes from this commit did the trick for us on custom code