Fix the issues reported by phpcs

Created on 25 April 2023, over 1 year ago

Updated 12 May 2023, over 1 year ago

Problem/Motivation

Coding Standard
htmlmail/src/Plugin/Mail/HtmlMailSystem.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
81 | ERROR | [ ] Missing member variable doc comment
82 | ERROR | [ ] Missing member variable doc comment
83 | ERROR | [ ] Missing member variable doc comment
293 | ERROR | [x] list(...) is forbidden, use [...] instead.
332 | ERROR | [x] list(...) is forbidden, use [...] instead.
472 | ERROR | [ ] The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------
htmlmail/src/Helper/HtmlMailHelper.php
--------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
73 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------
htmlmail/src/Utility/HtmlMailMime.php
--------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------
573 | ERROR | [x] Use null coalesce operator instead of ternary operator.
581 | ERROR | [x] Use null coalesce operator instead of ternary operator.
583 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------

Steps to reproduce

vendor/bin/phpcs --standard="Drupal,DrupalPractice" -n --extensions="php,module,inc,install,test,profile,theme" htmlmail/

Data model changes

📌 Task

Status

Closed: won't fix

Version

3.0

Component

Code

Created by

🇮🇳India Nishant

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Comments & Activities

Issue created by @Nishant
Comment over 1 year ago →
🇮🇳India Nishant
Created patch for the above coding standard issue.
Status changed to Needs review over 1 year ago11:32am 25 April 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
last update over 1 year ago
Patch Failed to Apply
Comment over 1 year ago →
🇮🇳India Nishant
Status changed to Closed: won't fix over 1 year ago6:13pm 12 May 2023
Comment over 1 year ago →
🇺🇸United States tr Cascadia
? Your patch is for the Captcha module, not the HTML Mail module.

diff --git a/captcha.install b/captcha.install index 0a9b263..65130f4 100755 --- a/captcha.install +++ b/captcha.install
Regardless, coding standards are the least of the problems with this module. Please read and contribute to 🌱 The future of the HTML Mail module Needs review if you need the functionality provided by the HTML Mail module.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024