Add Drupal 10 support

Created on 25 April 2023, almost 2 years ago
Updated 23 June 2023, over 1 year ago

Add Drupal 10 support by updating bef_select.info.yml file.

✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ͺπŸ‡ΈSpain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @plopesc
  • @plopesc opened merge request.
  • Status changed to Needs review almost 2 years ago
  • πŸ‡ͺπŸ‡ΈSpain plopesc Valladolid

    MR created

  • πŸ‡ͺπŸ‡ΈSpain psf_ Huelva

    +1
    We can't apply the patch before install it, and we can't install because don't have a composer.json file.

  • First commit to issue fork.
  • Status changed to Fixed over 1 year ago
  • πŸ‡΅πŸ‡±Poland Graber

    @psf maybe you can add a composer.json?

  • πŸ‡ͺπŸ‡ΈSpain psf_ Huelva

    Yes, tomorrow I find time to do it : )

  • Status changed to Needs work over 1 year ago
  • πŸ‡΅πŸ‡±Poland Graber

    Great, let’s add it here. I’m not using this on any of my current projects but can at least click the merge button πŸ˜‰

  • Assigned to psf_
  • πŸ‡ͺπŸ‡ΈSpain psf_ Huelva

    Nice :_ D

  • @psf_ opened merge request.
  • πŸ‡ͺπŸ‡ΈSpain psf_ Huelva

    I added the composer.json to a new branch, and now I can install it.

    To try we need two steps:

    1. Add a new repository to a working Drupal installation:

      The order it's important.

      ...
      "support": {
              "docs": "https://www.drupal.org/docs/user_guide/en/index.html",
              "chat": "https://www.drupal.org/node/314178"
          },
          "repositories": [
              {
                  "type": "git",
                  "url": "https://git.drupalcode.org/issue/bef_select-3356203.git"
              },
              {
                  "type": "composer",
                  "url": "https://packages.drupal.org/8"
              }
          ],
          "require": {
      ...
      
    2. After that we need require the module: composer require drupal/bef_select:dev-3356203-add-composer-json --prefer-source

      My composer respond with:

      ./composer.json has been updated
      Running composer update drupal/bef_select
      Gathering patches for root package.
      Loading composer repositories with package information
      Updating dependencies                                 
      Lock file operations: 1 install, 0 updates, 0 removals
        - Locking drupal/bef_select (dev-3356203-add-composer-json 18510bd)
      Writing lock file
      Installing dependencies from lock file (including require-dev)
      Package operations: 1 install, 0 updates, 0 removals
        - Syncing drupal/bef_select (dev-3356203-add-composer-json 18510bd) into cache
      Gathering patches for root package.
      Gathering patches for dependencies. This might take a minute.
        - Installing drupal/bef_select (dev-3356203-add-composer-json 18510bd): Cloning 18510bd367 from cache
        - Applying patches for drupal/bef_select
          https://git.drupalcode.org/project/bef_select/-/merge_requests/2/diffs.patch (#3356203 - Add Drupal 10 support)
      
      Generating autoload files
      48 packages you are using are looking for funding.
      Use the `composer fund` command to find out more!
      No security vulnerability advisories found
      

      Please, ignore the patch in the composer response :_ D It's my old project settings.

  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • πŸ‡ͺπŸ‡ΈSpain psf_ Huelva
  • Status changed to Fixed over 1 year ago
  • πŸ‡΅πŸ‡±Poland Graber

    Looks good, Will release that soon.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024