- Issue created by @dieterholvoet
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @dieterholvoet opened merge request.
- last update
over 1 year ago 12 pass - Status changed to Needs review
over 1 year ago 7:23am 25 April 2023 - Status changed to Needs work
over 1 year ago 8:53am 25 April 2023 - 🇩🇪Germany IT-Cru Munich
@DieterHolvoet: First quick view on your MR looks fine. I think we should add some warning message, that site builder should re-export image_style_warmer related config.
If possible we also should test this with some PHP Unit Function test.
I think we also should cleanup non-processed queue item in this hook, but this is also needed when an image file entity gets deleted. So I think this should be done in a separate issue, when this is merged.
- 🇧🇪Belgium dieterholvoet Brussels
I think we should add some warning message, that site builder should re-export image_style_warmer related config.
I'm not sure if that's necessary. Since the site builder just updated image style config, they will export their configuration again anyway.