- Issue created by @sidharth_soman
- @sidharth_soman opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:40am 25 April 2023 - 🇮🇳India sidharth_soman Bangalore
I have implemented the dependency injection and issued an MR. Please review.
- Assigned to arpitk
- Status changed to Needs work
over 1 year ago 11:12am 19 May 2023 - 🇮🇳India arpitk
Hi @sidharth_soman, I reviewed the MR and found an issue. with UserPasswordFormAlter class. The $container->get('entity_type.manager') container is missing which is causing this error as follows:
ArgumentCountError: Too few arguments to function Drupal\decoupled_auth\Form\UserPasswordFormAlter::__construct(), 2 passed in /app/web/modules/contrib/decoupled_auth-3356179/src/Form/UserPasswordFormAlter.php on line 58 and exactly 3 expected in Drupal\decoupled_auth\Form\UserPasswordFormAlter->__construct() (line 46 of /app/web/modules/contrib/decoupled_auth-3356179/src/Form/UserPasswordFormAlter.php)
There are few more issue reported by phpcs here:
FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/decoupled_auth-3356179/src/DecoupledAuthSettingsForm.php --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 117 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/decoupled_auth-3356179/tests/src/Functional/RegistrationTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
Moving the issue to Needs work and updating the MR.
Thanks!
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:24am 19 May 2023