- Issue created by @Shiv_Sharma
- Status changed to Needs review
over 1 year ago 6:24am 24 April 2023 - 🇺🇸United States earlyburg
Your patch degrades the function of the module.
If I applied it, users would no longer be able to chose a node type to display and would only be able to display the page node type. - 🇮🇳India Shiv_Sharma
@earlyburg thank you for your feedback . I was my bad I put the static value. now I made it correct.
and also I gone through the configurations.1> Added node on respective content type.
2> Configured respective content type on 'admin/config/random_frontpage/adminsettings'.
3> Added '/frontpage' value on Frontpage label on admin/config/system/site-information page.Please let me know if I need to to any other configuration for same.
Also i have gone through the some Drupal documentation seems the is no harm to add the access check.
https://www.drupal.org/node/3201242 →
https://www.drupal.org/project/consumers/issues/3245275 → - 🇺🇸United States earlyburg
I have added the access checks for node queries and also added module specific admin access permissions in the latest release available here:
https://www.drupal.org/project/random_frontpage/releases/2.0.0-beta7 →
- 🇮🇳India shashank5563 New Delhi
@earlyburg, I have reviewed the latest version(2.0.0-beta7) of the module, and they look fine to me.
I am moving it RTBC.
- Status changed to RTBC
over 1 year ago 12:45pm 24 April 2023 - 🇮🇳India Shiv_Sharma
@earlyburg new version 2.0.0-beta7 working fine.
Drupal 10.0.8
PHP 8.1.16 - Issue was unassigned.
- Status changed to Closed: works as designed
over 1 year ago 12:24pm 3 August 2023