- Issue created by @dieterholvoet
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @dieterholvoet opened merge request.
- last update
over 1 year ago 12 pass - Status changed to Needs review
over 1 year ago 9:48am 25 April 2023 - last update
over 1 year ago 12 pass - last update
over 1 year ago 12 pass - last update
over 1 year ago 12 pass - π§πͺBelgium dieterholvoet Brussels
I made the process more efficient when using queues. File entities are not being loaded anymore, queue items are being created for all files regardless of them passing validation since validation is being run during queue processing as well. This performance improvement is crucial when updating an image style that has thousands of derivatives, now the whole queueing process is near instant instead of taking 10 minutes or more in my case.
- π©πͺGermany IT-Cru Munich
@DieterHolvoet: How we detect if an image style is edited or deleted? I think also delete triggers this hook, which is than a potential problem.
I don't know if this will get into 8.x-1.2 release, but for 8.x-1.3 for sure.
- πΊπΈUnited States recrit
@IT-Cru: The hook_image_style_flush is called during
ImageStyle::save()
andImageStyle::delete()
. The MR 14 will be problematic in the following:
- When the image style config is deleted.
- When the image style config is imported during a deploy process. The MR 14 could trigger a new batch to run during the configuration import. - Status changed to Needs work
over 1 year ago 9:05am 21 June 2023 - π©πͺGermany IT-Cru Munich
Set to needs work, because I think we should think of possible problems which could be pop-up.