- Issue created by @joachim
- Status changed to Needs review
over 1 year ago 2:14pm 19 April 2023 - last update
over 1 year ago 29,282 pass, 2 fail - @joachim opened merge request.
- Status changed to Needs work
over 1 year ago 4:17pm 19 April 2023 - 🇬🇧United Kingdom joachim
What I don't understand is that when I run this test on 10.1.x, I can't see the contextual link that this line is testing:
> $link = $this->assertSession()->waitForElement('css', '[data-contextual-id^="node:node=1"] .contextual-links a:contains("Translate")');
- 🇬🇧United Kingdom joachim
> ->setLanguageAlterable(TRUE) is equivalent for $edit['settings[node][page][settings][language][language_alterable]'] = TRUE;. Don't we wan't to find the equivalent for 'settings[node][page][translatable]' ?
I'm cribbing from kernel tests, e.g. in EntityDefaultLanguageTest:
$content_type = $this->container->get('entity_type.manager')->getStorage('node_type')->create([ 'name' => 'Test ' . $name, 'title_label' => 'Title', 'type' => $name, 'create_body' => FALSE, ]); $content_type->save(); ContentLanguageSettings::loadByEntityTypeBundle('node', $name) ->setLanguageAlterable(FALSE) ->setDefaultLangcode($langcode) ->save();
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,300 pass - Status changed to Needs review
over 1 year ago 9:16pm 20 April 2023 - Status changed to RTBC
over 1 year ago 8:31am 21 April 2023 - 🇯🇵Japan tyler36 Osaka
Tested fine for me.
## Test:
- Installed on Drupal 10.1
- Added all core language module
- Install Japanese language
- Change site to Japanese
- Create new page content in Japanese - last update
over 1 year ago 29,302 pass - last update
over 1 year ago 29,304 pass - First commit to issue fork.
- last update
over 1 year ago 29,300 pass - 🇺🇸United States dww
Yes, please. Changes in the MR look great. This not only saves a form submit, but also a pointless login and logout. 🎉 Tests are still passing. MR needed a trivial rebase (which I did via the GitLab UI). But also recording here that I reviewed the diff and support this change.
- last update
over 1 year ago 29,362 pass - last update
over 1 year ago 29,366 pass - last update
over 1 year ago 29,367 pass - last update
over 1 year ago 29,374 pass - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Should be rebased again, but I agree with @dww, this is a good improvement.
- last update
over 1 year ago 29,378 pass - last update
over 1 year ago 29,379 pass 32:59 24:47 Running- last update
over 1 year ago 29,381 pass, 1 fail - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,387 pass, 2 fail 2:59 59:40 Running- last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,387 pass, 2 fail - last update
over 1 year ago 29,387 pass, 2 fail 2:59 0:50 Running- last update
over 1 year ago 29,399 pass - last update
over 1 year ago 29,398 pass, 2 fail - last update
over 1 year ago 29,400 pass - last update
over 1 year ago 29,409 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,418 pass - last update
over 1 year ago 29,420 pass - last update
over 1 year ago 29,420 pass 2:59 0:57 Running- Status changed to Fixed
over 1 year ago 2:34pm 14 June 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x, cherry-picked to 10.1.x and 10.0.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.