- Issue created by @wim leers
- Assigned to kunal.sachdev
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 2 years ago Not currently mergeable. - @kunalsachdev opened merge request.
- last update
over 2 years ago 744 pass - Issue was unassigned.
- Status changed to Needs review
over 2 years ago 10:23am 21 April 2023 - Assigned to omkar.podey
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
2 nits, then this is RTBC IMHO — unless @omkar.podey spots problems, of course! 😅
- Issue was unassigned.
- Status changed to Needs work
over 2 years ago 10:44am 21 April 2023 - Assigned to kunal.sachdev
- last update
over 2 years ago 744 pass - last update
over 2 years ago 744 pass - Issue was unassigned.
- Status changed to Needs review
over 2 years ago 11:39am 21 April 2023 - Assigned to kunal.sachdev
- Status changed to Needs work
over 2 years ago 12:52pm 21 April 2023 - 🇺🇸United States phenaproxima Massachusetts
I think this looks pretty good. IMHO we don't need to explain whether we return a boolean or not; that's written into the code itself by the return type hint. So I suggested a couple of rephrases, but other than that I approve of this!
- last update
over 2 years ago Custom Commands Failed - last update
over 2 years ago Custom Commands Failed - last update
over 2 years ago 758 pass - Assigned to phenaproxima
- Status changed to Needs review
over 2 years ago 1:31pm 21 April 2023 - last update
over 2 years ago 758 pass - Issue was unassigned.
- Status changed to RTBC
over 2 years ago 1:35pm 21 April 2023 - last update
over 2 years ago 758 pass -
phenaproxima →
committed 06404eaa on 3.0.x authored by
kunal.sachdev →
Issue #3355045 by kunal.sachdev, omkar.podey, Wim Leers: StageBase...
-
phenaproxima →
committed 06404eaa on 3.0.x authored by
kunal.sachdev →
- Status changed to Fixed
over 2 years ago 2:09pm 21 April 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Marking as core-mvp because the docs were wrong not just incomplete
Automatically closed - issue fixed for 2 weeks with no activity.
