Coding Standard

Issue created by @Neha Wadhwani
Status changed to Needs review over 1 year ago7:10am 19 April 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
5 pass
Comment over 1 year ago →
🇮🇳India Neha Wadhwani
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
5 pass

Getting below Hunk after applying patch

sourabhjain@LPT-SOURABH time_field % git apply -v coding_standard-3355025-2.patch.txt                                                                       
Checking patch src/Time.php...
Hunk #1 succeeded at 152 (offset -13 lines).
Applied patch src/Time.php cleanly.

Created new patch and fixed more PHPCS issue. Please review.

Status changed to Closed: won't fix over 1 year ago9:58am 19 April 2023
Comment over 1 year ago →
🇧🇪Belgium BramDriesen Belgium 🇧🇪
To discourage people from adding issues, patches or MRs that appear to seek easy commit credits I will not be merging these types of requests. Generally, these tickets create unnecessary noise and maintainer workload.
If however you feel I'm unfairly confused a meaningful contribution with attempts motivated by earning commit credit, please respond and let me know. I don't want to stand in the way of genuine contribution, only to preserve the valuable time and energy available in the community for meaningful efforts. If I've got this wrong, I want to hear from you.

Problem/Motivation

Comments & Activities