Contrib.social

Fix the issues reported by PHPCS

Open on Drupal.org →
Created on 18 April 2023, about 1 year ago
Updated 21 April 2023, about 1 year ago

Problem/Motivation

FILE: ...l10/web/modules/contrib/vlsuite/modules/vlsuite_block/vlsuite_block.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
103 | ERROR | [x] Case breaking statements must be followed by a single blank
| | line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...10/web/modules/contrib/vlsuite/modules/vlsuite_block/css/vlsuite-block.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../web/modules/contrib/vlsuite/modules/vlsuite_layout/css/vlsuite-layout.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...contrib/vlsuite/modules/vlsuite_bundle_field/vlsuite_bundle_field.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...trib/vlsuite/modules/vlsuite_layout_builder/css/vlsuite-layout-builder.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
405 | ERROR | [x] Expected 1 space after colon in style definition; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...html/contribution/drupal10/web/modules/contrib/vlsuite/vlsuite.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use "administer
| | site configuration" - which implies the user can change
| | something - rather than "access administration pages" which is
| | about viewing but not changing configurations.
--------------------------------------------------------------------------------

Time: 2.87 secs; Memory: 14MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig vlsuite/

Proposed resolution

Fix all the issues after executing PHPCBF command.

Remaining tasks

Patch review.

📌 Task
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    🇵🇭Philippines kenyoOwen

    Hi urvashi_vora

    I applied the patch to the “Visual Layout Suite (VLSuite)” module against Version 1.0.x - dev coding-standard-fixes.patch → and confirmed that the errors is resolved. Please see the screenshots attached.

    For your review.
    Thank you.

  • Status changed to Closed: won't fix about 1 year ago
  • Comment about 1 year ago →
    🇪🇸Spain tunic Madrid

    This module is under heavy development. It doesn't have even an alpha release because of this. The code changes everyday. The patch is done using automatic tools with a low human effort. Because the previous reasons I think this patch is a clear credit farming attempt. It doesn't apply, by the way. Therefore, I'm closing this as won't fix.

    To get more information of useful contributions please refer to https://www.previousnext.com.au/blog/5-simple-tips-increase-your-drupal-..., specially tip 2.

    Thanks for your understanding.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024