Coding standards

Open on Drupal.org →

Created on 17 April 2023, over 1 year ago

Updated 18 April 2023, over 1 year ago

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/collapsiblock/

FILE: /var/www/html/drupalvb/web/modules/contrib/collapsiblock/src/Form/CollapsiblockGlobalSettings.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 10 WARNINGS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
40 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
45 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
47 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
51 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
53 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
71 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/collapsiblock/tests/src/Functional/GlobalConfigurationTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/collapsiblock/tests/src/Functional/BlockInstanceTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/collapsiblock/collapsiblock.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/collapsiblock/collapsiblock.libraries.yml
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
12 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/collapsiblock/collapsiblock.module
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | [ ] Global constants should not be used, move it to a class or interface
51 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
105 | ERROR | [x] Each PHP statement must be on a line by itself
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY

📌 Task

Status

Closed: duplicate

Version

3.0

Component

Code

Created by

🇮🇳India dineshkumarbollu

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Issue created by @dineshkumarbollu
Comment over 1 year ago →
🇦🇺Australia darvanen Sydney, Australia
Hello @dineshkumarbollu,

Please be informed that I have a policy of not providing commit credit for code standards updates to users who have already received a credit for such. I also expect any added comments to be *useful*, not just boilerplate code.

Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 7.4 & MySQL 8
last update over 1 year ago
Unable to generate test groups
@dineshkumarbollu opened merge request.
Comment over 1 year ago →
🇮🇳India dineshkumarbollu
Hi darvanen

It has unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option,
That's why i am doing coding standards not only comment/annotations i am also checking is there any deprecated function are exists in code and checking Dependency Injection.

Credits are not my primary focus I am new to Drupal I am learning how Industry writing code which is best at production.

Thanks
Issue was unassigned.
Status changed to Closed: duplicate over 1 year ago10:52pm 18 April 2023
Comment over 1 year ago →
🇦🇺Australia darvanen Sydney, Australia
Oh I just noticed this is for the 3.x branch, that is no longer under active development as I noted in 📌 t() calls should be avoided in classes and unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. Closed: won't fix . You should scan for existing issues before opening new ones.

I assure you the use of unserialize on the constant defined in this module is safe. It may not be best practice, and that is why it has been changed in the active branch.

Closing as duplicate of 📌 t() calls should be avoided in classes and unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. Closed: won't fix

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024