- Issue created by @Jiskra
- Status changed to Needs work
over 1 year ago 11:16am 13 April 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thanks @Jiskra - could you please provide a MR instead of a patch and keep the dependency injection ($this->configFactory)?
- First commit to issue fork.
- last update
about 1 year ago 88 pass - @j-lee opened merge request.
- Status changed to Needs review
about 1 year ago 4:54am 27 September 2023 - last update
about 1 year ago 88 pass - 🇩🇪Germany Anybody Porta Westfalica
Thank you @J-Lee! MR looks good, now we need someone to test it or even better add a simple test case for this to ensure it works in the future.
- Assigned to J-Lee
- last update
about 1 year ago 88 pass, 2 fail - Status changed to Needs work
about 1 year ago 8:35am 27 September 2023 - Status changed to Needs review
about 1 year ago 9:18am 27 September 2023 - 🇩🇪Germany J-Lee 🇩🇪🇪🇺
I have problems with the local test environment and a chmod permission problem, so I will test here.
- 🇩🇪Germany Anybody Porta Westfalica
Off-topic: @Jiskra you may want to try https://github.com/webksde/ddev-vscode-devcontainer-drupal9-template
Batteries and testing included with just two commands ;) - Status changed to Needs work
about 1 year ago 7:51am 28 September 2023 - 🇩🇪Germany Grevil
@Anybody, I think you meant @J-Lee?
Still one test fails, see https://git.drupalcode.org/issue/cookies-3353972/-/jobs/120727.
- Status changed to Needs review
about 1 year ago 6:28am 29 September 2023 - 🇩🇪Germany J-Lee 🇩🇪🇪🇺
I think I fixed the new tests for the default stylesheet behavior.
As a followup, perhaps a test base class could be created to better organize the tests.Sorry for the long wait but I had to fix my dev environment first. Thanks @Anybody for the link.
- Issue was unassigned.
- Status changed to RTBC
about 1 year ago 12:57pm 29 September 2023 - Status changed to Fixed
about 1 year ago 1:04pm 29 September 2023 - 🇩🇪Germany Grevil
As a followup, perhaps a test base class could be created to better organize the tests
There is a test base class for functional js tests, btw! But yea, I agree, that one for normal functional tests could be beneficial!
Automatically closed - issue fixed for 2 weeks with no activity.