Contrib.social

Fix the issues reported by PHPCS

Open on Drupal.org →
Created on 13 April 2023, almost 2 years ago
Updated 28 April 2023, over 1 year ago

Problem/Motivation

FILE: ...web/modules/contrib/payment_donation_block/payment_donation_block.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------

FILE: ...contribution/drupal10/web/modules/contrib/payment_donation_block/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
12 | WARNING | Line exceeds 80 characters; contains 127 characters
16 | WARNING | Line exceeds 80 characters; contains 85 characters
25 | WARNING | Line exceeds 80 characters; contains 86 characters
28 | WARNING | Line exceeds 80 characters; contains 106 characters
--------------------------------------------------------------------------------

FILE: .../modules/contrib/payment_donation_block/payment_donation_block.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use "administer
| | site configuration" - which implies the user can change
| | something - rather than "access administration pages" which is
| | about viewing but not changing configurations.
--------------------------------------------------------------------------------

FILE: ...eb/modules/contrib/payment_donation_block/src/Form/PaymentDonationForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
84 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------

Time: 435ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig payment_donation_block/

Proposed resolution

Resolve all the issues for Drupal and DrupalPractice coding standards

Remaining tasks

Patch Review

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024