Call to undefined method Symfony\\Component\\HttpFoundation\\RequestStack::getMasterRequest() in Domain Config UI when editing domain-specific site information

Actual Behavior

Apparently, nothing happens. Looking in further, it looks like in module domain_config_ui, on the SwitchForm switchCallback function, it requests an unknown (for D10) function in requestStack.

Code looks like

$request = \Drupal::service('request_stack')->getMasterRequest();

while it should be

$request = version_compare(\Drupal::VERSION, '9.3', '>=') ? \Drupal::service('request_stack')->getMainRequest() : \Drupal::service('request_stack')->getMasterRequest();

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Issue created by @fadeslayer
Comment over 1 year ago →
🇮🇹Italy fadeslayer
I created a patch for this issue, feel free to evaluate and make changes.
Comment over 1 year ago →
🇮🇹Italy fadeslayer
Comment over 1 year ago →
🇳🇱Netherlands idebr
Comment over 1 year ago →
System Message
The last submitted patch, 2: 3353885-call-to-undefined-getmasterrequest-in-domain-config-ui-switchform-class.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.
Status changed to Needs work over 1 year ago9:06am 18 April 2023
Comment over 1 year ago →
🇮🇹Italy fadeslayer
Comment over 1 year ago →
🇨🇳China hongqing
I tested this patch. The domain at the Default front page does not switch, it always keeps the current domain. It needs to change the current domain to change the settings of the specific domain. Luckily, although it needs to change the current domain to change the settings, the settings work well.
Comment over 1 year ago →
🇺🇸United States bcobin
Thank you! I manually patched the module and the name now seems to "stick." I thought I was losing my mind... thanks!
Status changed to Closed: outdated 5 months ago9:40pm 21 July 2024
Comment 5 months ago →
davps
This issue was fixed in 🐛 SwitchForm compatibility with Drupal 10 Fixed

Call to undefined method Symfony\\Component\\HttpFoundation\\RequestStack::getMasterRequest() in Domain Config UI when editing domain-specific site information

Drupal version: 10.0.7

Domain module version: 2.0.x

Expected Behavior

Actual Behavior

Comments & Activities