Drupal 10 Compatibility Fixes

Created on 12 April 2023, over 1 year ago
Updated 8 November 2023, about 1 year ago

Creating this issue to make this module Drupal 10 compatible.

Upgrade_status errors:

modules/contrib/livechat/livechat.libraries.yml:
The 'livechat_admin' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256

modules/contrib/livechat/livechat.info.yml:
Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇮🇳India abhinavk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @abhinavk
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India abhinavk

    I have fixed Upgrade status errors and also below drupal-check error and created patch for same.
    Please review the patch.

    drupal-check error:
    $ drupal-check livechat
    4/4 [============================] 100%

    ------ ----------------------------------------------------------------------------------
    Line livechat.install
    ------ ----------------------------------------------------------------------------------
    16 Method Drupal\Core\Config\Config::get() invoked with 2 parameters, 0-1 required.
    ------ ----------------------------------------------------------------------------------

    [ERROR] Found 1 error

  • 🇮🇳India rahul1707

    I have tested patch #3 on Drupal 9.5.7 and 10.0.3 and PHP 8.1. Patch applied cleanly, functionality is working as expected and making this module D10 compatible. Checked with upgrade status, no issue found.
    So, moving this to RTBC.

  • Status changed to RTBC over 1 year ago
    • ae787bdb committed on 8.x-3.x
      Issue #3353733 by AbhinavK, rahul1707: Drupal 10 Compatibility Fixes
      
  • Status changed to Fixed over 1 year ago
  • 🇺🇸United States markie Albuquerque, NM

    Thanks for this. I have committed and will start a release plan ticket. For now the dev version would be D10 compatible.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed about 1 year ago
  • 🇬🇧United Kingdom guy_schneerson

    would be nice to get a stable release with D10 support.
    not a big issue as can use the dev or the patch.

Production build 0.71.5 2024