Contrib.social

Fix the issues reported by PHPCS

Open on Drupal.org →
Created on 12 April 2023, over 1 year ago
Updated 2 May 2023, over 1 year ago

Problem/Motivation

FILE: ...bution/drupal10/web/modules/contrib/clip/js/form/media-entity-edit-form.js
--------------------------------------------------------------------------------
FOUND 43 ERRORS AFFECTING 43 LINES
--------------------------------------------------------------------------------
19 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
26 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
32 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
39 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
51 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
60 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
69 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
79 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
165 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
171 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
190 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
194 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
202 | ERROR | [x] Whitespace found at end of line
210 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
221 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
230 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
238 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
242 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
243 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
250 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
251 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
258 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
259 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
263 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
264 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
269 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
270 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
274 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
275 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
280 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
281 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
285 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
286 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
290 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
291 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
295 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
304 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
308 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
309 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
314 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
322 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
323 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 43 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...contribution/drupal10/web/modules/contrib/clip/js/player/player.videojs.js
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
13 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
| | found "true"
49 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ww/html/contribution/drupal10/web/modules/contrib/clip/js/player/player.js
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
92 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 5 spaces but found 3 spaces
93 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 3 spaces but found 1 space
94 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 3 spaces but found 1 space
95 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 4 spaces but found 2 spaces
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/contribution/drupal10/web/modules/contrib/clip/README.md
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 21 WARNINGS AFFECTING 21 LINES
----------------------------------------------------------------------------
28 | WARNING | Line exceeds 80 characters; contains 93 characters
34 | WARNING | Line exceeds 80 characters; contains 95 characters
38 | WARNING | Line exceeds 80 characters; contains 81 characters
42 | WARNING | Line exceeds 80 characters; contains 89 characters
45 | WARNING | Line exceeds 80 characters; contains 84 characters
59 | WARNING | Line exceeds 80 characters; contains 93 characters
60 | WARNING | Line exceeds 80 characters; contains 94 characters
72 | WARNING | Line exceeds 80 characters; contains 102 characters
73 | WARNING | Line exceeds 80 characters; contains 104 characters
77 | WARNING | Line exceeds 80 characters; contains 82 characters
80 | WARNING | Line exceeds 80 characters; contains 95 characters
81 | WARNING | Line exceeds 80 characters; contains 89 characters
82 | WARNING | Line exceeds 80 characters; contains 97 characters
85 | WARNING | Line exceeds 80 characters; contains 96 characters
86 | WARNING | Line exceeds 80 characters; contains 83 characters
89 | WARNING | Line exceeds 80 characters; contains 96 characters
90 | WARNING | Line exceeds 80 characters; contains 97 characters
93 | WARNING | Line exceeds 80 characters; contains 97 characters
99 | WARNING | Line exceeds 80 characters; contains 100 characters
100 | WARNING | Line exceeds 80 characters; contains 101 characters
101 | WARNING | Line exceeds 80 characters; contains 100 characters
----------------------------------------------------------------------------

FILE: ...ww/html/contribution/drupal10/web/modules/contrib/clip/src/Entity/Clip.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
31 | ERROR | [x] Missing function doc comment
63 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ion/drupal10/web/modules/contrib/clip/src/Service/ClipFactoryInterface.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Missing interface doc comment
8 | ERROR | [x] Missing function doc comment
8 | ERROR | [x] Expected 1 blank line before function; 0 found
8 | ERROR | [x] Expected 1 blank line after function; 0 found
9 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 blank line after function; 0 found
10 | ERROR | [x] The closing brace for the interface must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...bution/drupal10/web/modules/contrib/clip/src/Service/UrlWrapperFactory.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
9 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 blank line before function; 0 found
24 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...contribution/drupal10/web/modules/contrib/clip/src/Service/ClipFactory.php
--------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
12 | ERROR | [ ] Missing member variable doc comment
14 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [x] Missing function doc comment
17 | ERROR | [x] Opening brace should be on the same line as the declaration
22 | ERROR | [x] Missing function doc comment
23 | ERROR | [x] Opening brace should be on the same line as the declaration
27 | ERROR | [x] Missing function doc comment
28 | ERROR | [x] Opening brace should be on the same line as the declaration
34 | ERROR | [x] Expected 1 blank line after function; 0 found
35 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...upal10/web/modules/contrib/clip/src/Service/UrlWrapperFactoryInterface.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Missing interface doc comment
8 | ERROR | [x] Missing function doc comment
8 | ERROR | [x] Expected 1 blank line before function; 0 found
8 | ERROR | [x] Expected 1 blank line after function; 0 found
9 | ERROR | [x] The closing brace for the interface must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ml/contribution/drupal10/web/modules/contrib/clip/src/Controller/Media.php
--------------------------------------------------------------------------------
FOUND 19 ERRORS AFFECTING 19 LINES
--------------------------------------------------------------------------------
18 | ERROR | [x] Missing class doc comment
19 | ERROR | [ ] Missing member variable doc comment
21 | ERROR | [ ] Missing member variable doc comment
23 | ERROR | [ ] Missing member variable doc comment
25 | ERROR | [ ] Missing member variable doc comment
27 | ERROR | [ ] Missing member variable doc comment
29 | ERROR | [ ] Missing short description in doc comment
34 | ERROR | [ ] Missing short description in doc comment
39 | ERROR | [ ] Missing short description in doc comment
44 | ERROR | [x] Missing function doc comment
45 | ERROR | [x] Expected 1 space between type hint and argument
| | "$entity_type_manager"; 4 found
46 | ERROR | [x] Expected 1 space between type hint and argument
| | "$route_match"; 11 found
47 | ERROR | [x] Expected 1 space between type hint and argument "$yaml"; 26
| | found
48 | ERROR | [x] Expected 1 space between type hint and argument
| | "$kill_switch"; 20 found
56 | ERROR | [x] Missing function doc comment
65 | ERROR | [x] Missing function doc comment
96 | ERROR | [x] Missing function doc comment
98 | ERROR | [x] Expected 1 blank line after function; 0 found
99 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...www/html/contribution/drupal10/web/modules/contrib/clip/src/UrlWrapper.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
5 | ERROR | [x] Missing class doc comment
7 | ERROR | [ ] Missing member variable doc comment
9 | ERROR | [x] Missing function doc comment
13 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...contribution/drupal10/web/modules/contrib/clip/src/UrlWrapperInterface.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
5 | ERROR | [x] Missing interface doc comment
7 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Missing function doc comment
11 | ERROR | [x] Missing function doc comment
13 | ERROR | [x] Missing function doc comment
15 | ERROR | [x] Missing function doc comment
17 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../drupal10/web/modules/contrib/clip/src/Form/AddRemoteVideoEntitiesForm.php
--------------------------------------------------------------------------------
FOUND 30 ERRORS AND 2 WARNINGS AFFECTING 32 LINES
--------------------------------------------------------------------------------
23 | ERROR | [x] Missing class doc comment
25 | ERROR | [ ] Missing member variable doc comment
27 | ERROR | [ ] Missing member variable doc comment
29 | ERROR | [ ] Missing member variable doc comment
31 | ERROR | [ ] Missing member variable doc comment
33 | ERROR | [ ] Missing member variable doc comment
35 | ERROR | [ ] Missing short description in doc comment
40 | ERROR | [x] Missing function doc comment
41 | ERROR | [x] Expected 1 space between type hint and argument
| | "$entity_repository"; 5 found
42 | ERROR | [x] Expected 1 space between type hint and argument
| | "$entity_type_manager"; 4 found
44 | ERROR | [x] Expected 1 space between type hint and argument "$time";
| | 17 found
45 | ERROR | [x] Expected 1 space between type hint and argument
| | "$moduleExtensionList"; 11 found
46 | ERROR | [x] Expected 1 space between type hint and argument
| | "$formFactory"; 10 found
47 | ERROR | [x] Expected 1 space between type hint and argument "$kits"; 6
| | found
48 | ERROR | [x] Expected 1 space between type hint and argument
| | "$clipFactory"; 10 found
49 | ERROR | [x] Expected 1 space between type hint and argument
| | "$urlWrapperFactory"; 4 found
50 | ERROR | [x] Expected 1 space between type hint and argument "$yaml";
| | 26 found
51 | ERROR | [x] Expected 1 space between type hint and argument
| | "$messenger"; 12 found
66 | ERROR | [x] Missing function doc comment
82 | ERROR | [x] Missing function doc comment
86 | ERROR | [x] Missing function doc comment
111 | ERROR | [x] Missing function doc comment
121 | WARNING | [ ] Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
151 | WARNING | [ ] Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
173 | ERROR | [x] Missing function doc comment
207 | ERROR | [x] Missing function doc comment
213 | ERROR | [x] Missing function doc comment
225 | ERROR | [x] Missing function doc comment
240 | ERROR | [x] Missing function doc comment
247 | ERROR | [x] Missing function doc comment
254 | ERROR | [ ] Missing short description in doc comment
257 | ERROR | [x] Visibility must be declared on method "hasStringKeys"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../contribution/drupal10/web/modules/contrib/clip/src/Form/EditMediaForm.php
--------------------------------------------------------------------------------
FOUND 33 ERRORS AND 2 WARNINGS AFFECTING 35 LINES
--------------------------------------------------------------------------------
22 | ERROR | [x] Missing class doc comment
24 | ERROR | [ ] Missing member variable doc comment
26 | ERROR | [ ] Missing member variable doc comment
28 | ERROR | [ ] Missing member variable doc comment
30 | ERROR | [ ] Missing member variable doc comment
32 | ERROR | [ ] Missing member variable doc comment
34 | ERROR | [x] Missing function doc comment
35 | ERROR | [x] Expected 1 space between type hint and argument
| | "$entity_repository"; 5 found
36 | ERROR | [x] Expected 1 space between type hint and argument
| | "$entity_type_manager"; 4 found
38 | ERROR | [x] Expected 1 space between type hint and argument "$time";
| | 17 found
39 | ERROR | [x] Expected 1 space between type hint and argument
| | "$moduleExtensionList"; 11 found
40 | ERROR | [x] Expected 1 space between type hint and argument
| | "$formFactory"; 10 found
41 | ERROR | [x] Expected 1 space between type hint and argument "$kits"; 6
| | found
42 | ERROR | [x] Expected 1 space between type hint and argument
| | "$clipFactory"; 10 found
56 | ERROR | [x] Missing function doc comment
70 | ERROR | [x] Missing function doc comment
79 | ERROR | [x] A unary operator statement must not be followed by a space
103 | ERROR | [x] Missing function doc comment
107 | ERROR | [x] Missing function doc comment
109 | ERROR | [x] A unary operator statement must not be followed by a space
155 | ERROR | [x] Missing function doc comment
159 | ERROR | [x] Missing function doc comment
174 | ERROR | [x] Missing function doc comment
180 | ERROR | [x] Missing function doc comment
182 | WARNING | [x] '@todo ->setSticky()' should match the format '@todo Fix
| | problem X here.'
206 | ERROR | [x] Missing function doc comment
208 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
211 | ERROR | [x] Missing function doc comment
218 | ERROR | [x] Missing function doc comment
233 | ERROR | [x] Missing function doc comment
244 | ERROR | [x] Missing function doc comment
248 | ERROR | [x] Missing function doc comment
252 | ERROR | [x] Missing function doc comment
262 | ERROR | [x] Missing function doc comment
272 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...l/contribution/drupal10/web/modules/contrib/clip/src/YouTubeUrlWrapper.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
5 | ERROR | [x] Missing class doc comment
7 | ERROR | [x] Missing function doc comment
11 | ERROR | [x] Missing function doc comment
20 | ERROR | [x] Missing function doc comment
24 | ERROR | [x] Missing function doc comment
31 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/contribution/drupal10/web/modules/contrib/clip/clip.module
------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
1 | ERROR | [x] Missing file doc comment
25 | ERROR | [x] Expected 1 blank line after function; 2 found
28 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

Time: 1.12 secs; Memory: 12MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig clip/

Proposed resolution

Fix all errors and warning for Drupal and DrupalPractice coding standards

Remaining tasks

Patch review.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024