- Issue created by @Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: I think this shouldn't be too hard. When looping the entities in the fields, it's just an early exit or comparing the values. And the form element is also simple.
Please use the same keys and values as Webform does for example, but leave out the XOR, I don't think it makes a lot of sense here:
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: I think this will be an easy one. The most important thing here is to have tests in place. Especially to not break the OR (=Any) existing behavior.
- 🇩🇪Germany Grevil
I added the form and schema implementation. Tomorrow I will start with the logic.
- last update
almost 2 years ago 18 pass - @grevil opened merge request.
- Status changed to Needs review
almost 2 years ago 9:49am 5 May 2023 - 🇩🇪Germany Grevil
Done, please review! All tests and newly added tests are green locally! Let's see what Jenkins has to say about them.
I also found a bug in code, not properly handling multiple referenced entities (as there were no tests for that use case before). All fixed now! :)
- Status changed to Needs work
almost 2 years ago 9:57am 5 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
Great work @Grevil once again :)
Especially nice tests and super important bugfix!I left some comments for final adjustments.
What about an update-path? That will definitely be needed for existing installations. Or does it fallback to 'or' gracefully if the value is not set? (might be more stable and safer than an update hook).
After merge we should test this carefully in our projects, where this module is used, before we tag a release.
- last update
almost 2 years ago 18 pass - 🇩🇪Germany Grevil
Fixed the remaining adjustments, good call with the update path! It will only fallback gracefully for the form, but not to the fields itself!! THX!
- last update
almost 2 years ago 18 pass - Status changed to Needs review
almost 2 years ago 10:52am 5 May 2023 - 🇩🇪Germany Grevil
Sorry, took a bit longer than expected, please review once again.
- last update
almost 2 years ago 18 pass - last update
almost 2 years ago 18 pass - 🇩🇪Germany Anybody Porta Westfalica
Fine! RTBC! :)
Note #8! Needs manual testing in dev to be 100% sure.
- last update
almost 2 years ago 18 pass - Status changed to Fixed
almost 2 years ago 11:25am 5 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.