- Issue created by @dieterholvoet
- πΊπΈUnited States kevinquillen
Hey Dieter, great idea. We should probably collaborate that in this module, that way you we aren't duplicating work.
https://www.drupal.org/project/openai β
There is a submodule for openai_dblog for example. I also had some thoughts here:
https://www.drupal.org/project/openai/issues/3338718 β¨ Add ability to manually add 'solution' to a watchdog log Closed: won't fix
I think we are on the right path here - but may make more sense as a submodule in that suite. Or require that module here... one or the other.
- π§πͺBelgium dieterholvoet Brussels
Iβm not sure you completely understand my intention here. This functionality was added to the Ignition package, all we would need to do is bridge it to this module through configuration. I donβt think that little code/configuration needs to be part of the OpenAI module, there wonβt be any custom logic.
- Assigned to matthieuscarset
- @matthieuscarset opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 2 years ago 10:40am 13 April 2023 - Status changed to Needs work
over 2 years ago 9:45am 14 April 2023 TY very much for review changes and feedback. I ll get back to work on this asap.
- Status changed to Needs review
over 2 years ago 6:54pm 18 April 2023 - Status changed to RTBC
over 2 years ago 8:45am 20 April 2023 - π§πͺBelgium dieterholvoet Brussels
Looks good! I think we should wait for the following upstream issues to be fixed before actually releasing this:
Or what do you think?
- πΊπΈUnited States kevinquillen
Could the Markdown module be used to convert an incoming response from HTML?
- Status changed to Needs review
about 2 years ago 2:12pm 10 May 2023 - π§πͺBelgium dieterholvoet Brussels
That's not up to us to fix, it should be fixed upstream. I noticed this in the changelog of 1.6.0 though:
Add support for rendering markdown in solutions
This should probably be tested again with the latest version of the package.
- π§πͺBelgium dieterholvoet Brussels
- Status changed to Postponed
about 2 years ago 1:36pm 9 June 2023 - Status changed to Needs review
almost 2 years ago 7:21am 22 September 2023 - Status changed to Postponed
almost 2 years ago 7:46am 22 September 2023 - π§πͺBelgium dieterholvoet Brussels
Like I said in my previous comment, #264 is not fixed yet. We could just ignore that, release this feature and fix it in a follow-up though.
- π§πͺBelgium dieterholvoet Brussels
That issue is now actually fixed and releases, so this is now unblocked. Will try to finish ASAP.
- Status changed to Needs review
almost 2 years ago 2:24pm 18 October 2023 - π§πͺBelgium dieterholvoet Brussels
Apparently the Key module provides a built in way β to override any config value, so I don't think it's necessary to add explicit support here. There are many ways to override config, including Drupal core's way.
-
DieterHolvoet β
committed 28bca588 on 1.0.x authored by
matthieuscarset β
Issue #3353653 by DieterHolvoet, matthieuscarset: Add support for AI...
-
DieterHolvoet β
committed 28bca588 on 1.0.x authored by
matthieuscarset β
- Status changed to Fixed
almost 2 years ago 12:29pm 20 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.