- Issue created by @Rajab Natshah
- @rajab-natshah opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:48pm 11 April 2023 - Status changed to Needs work
over 1 year ago 2:04pm 11 April 2023 - πΊπΈUnited States mglaman WI, USA
Hm, that means the default config is wrong. Also, we could use
?:
to ensure an array$metrics_dimensions = $ga_settings->get('custom.parameters') ?: [];
- Status changed to RTBC
over 1 year ago 4:07pm 11 April 2023 - πΊπΈUnited States mglaman WI, USA
Looks great! I forgot
custom.parameters
is coming fromgoogle_analytics.settings
and we cannot control it's value. I was reading it backwards as our code somehow was providing null and not an array. -
mglaman β
committed af8ad203 on 2.0.x authored by
Rajab Natshah β
Issue #3353449 by Rajab Natshah: Fix TypeError: array_values(): Argument...
-
mglaman β
committed af8ad203 on 2.0.x authored by
Rajab Natshah β
- Status changed to Fixed
over 1 year ago 4:24pm 25 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.