Fixing the issues reported by phpcs

Created on 11 April 2023, almost 2 years ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sidharth_soman
  • Status changed to Needs work almost 2 years ago
  • 🇮🇳India sidharth_soman Bangalore

    Finding the above issues as detailed in the issue summary upon running the codesniffer on the module. I'll work on fixing them.

  • @sidharth_soman opened merge request.
  • 🇮🇳India sidharth_soman Bangalore

    I've fixed the issues except for those regarding unused variables as they are used for convenience in the forEach loop.
    I have created an MR. Please review.

  • Issue was unassigned.
  • Status changed to RTBC almost 2 years ago
  • 🇵🇭Philippines kenyoOwen

    Hi sidharth_soman

    I applied your MR and confirmed it that the errors and warnings are resolved except for the unused variables. Please see the screenshots attached.

    For your review.
    Thank you.

  • Status changed to Closed: outdated about 2 months ago
  • 🇪🇸Spain marcoscano Barcelona, Spain

    Thank you for contributing, let's please fix this as part of 📌 Clean up and improve CI jobs Active .

Production build 0.71.5 2024