- Issue created by @duaelfr
- @duaelfr opened merge request.
- Status changed to Needs review
over 1 year ago 8:28pm 10 April 2023 - 🇫🇷France duaelfr Montpellier, France
This MR is built on top of !29 from 📌 [2.0.x] Move YAML discovery from ui_patterns_library to ui_patterns Fixed
- last update
over 1 year ago 50 pass - First commit to issue fork.
- last update
over 1 year ago 60 pass - last update
over 1 year ago 59 pass - last update
over 1 year ago 72 pass - 🇫🇷France duaelfr Montpellier, France
Job done.
Bonus: here is a patch to deprecate the method in the 1.x branch - Assigned to Grimreaper
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
Thanks looking at the MR.
Here is my comment for the deprecation patch.
+++ b/src/Element/PatternPreview.php @@ -52,6 +52,9 @@ public static function processFields(array $element) { if (is_array($preview)) {
Should we also add a trigger_error? like
@trigger_error('AddressField is deprecated in address:8.x-1.3 and is removed from address:8.x-2.0. Use \Drupal\address\Plugin\migrate\field\AddressField instead. See https://www.drupal.org/project/address/issues/2912087', E_USER_DEPRECATED);
-
Grimreaper →
committed 0aa57509 on 2.0.x authored by
DuaelFr →
Issue #3353287 by DuaelFr, Grimreaper: [2.0.x] Remove unused escape...
-
Grimreaper →
committed 0aa57509 on 2.0.x authored by
DuaelFr →
- Issue was unassigned.
- 🇫🇷France Grimreaper France 🇫🇷
MR merged on 2.0.x. Thanks!
Changing branch for the deprecation on 8.x-1.x.
- last update
over 1 year ago 72 pass - Assigned to Grimreaper
-
Grimreaper →
committed 90fba88e on 8.x-1.x authored by
DuaelFr →
Issue #3353287 by DuaelFr, Grimreaper: Mark PatternPreview::...
-
Grimreaper →
committed 90fba88e on 8.x-1.x authored by
DuaelFr →
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 4:14pm 1 June 2023 - 🇫🇷France Grimreaper France 🇫🇷
Merged.
Thanks. I have adapted the message to pass PHPCS.
Automatically closed - issue fixed for 2 weeks with no activity.