- Issue created by @igor mashevskyi
- @igor-mashevskyi opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:12am 7 April 2023 - 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Great work on this! +1 To invite users to test and review it on Drupal 10 we first need to commit the standard compatibility patch by adding the
... || ^10
to the core requirement setting of the info file. Usually this gets opened automatically by the update bot, not sure if the issue already exist. - 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Yup. and here it is: https://www.drupal.org/project/domain/issues/3287020 📌 Automated Drupal 10 compatibility fixes Needs review
Domains are config entities, so calling
accessCheck()
on entity queries is not needed (and doesn't do anything). Automated code scans (such as in Upgrade Status) might flag this as an issue because they aren't able to tell what kind of entity the query is being run on.- Status changed to Closed: outdated
6 months ago 9:36pm 21 July 2024 This issue was fixed it this commit https://git.drupalcode.org/project/domain/-/commit/fb5aa79ea6377efe000d5...