- Issue created by @mandclu
- @mandclu opened merge request.
- Status changed to Needs review
over 1 year ago 5:28pm 5 April 2023 - π¨π¦Canada mandclu
Added a commit to include my suggestion for updated labels, as originally raised in π "Toggle Preview" button isn't a toggle Closed: duplicate
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Does this solution also have issues loading for new content?
- π¨π¦Canada mandclu
This approach works for both new and existing content, based on my testing.
- π¨π¦Canada mandclu
Pushed a new commit, with a few improvements:
- I noticed that the toggle would lose focus when changed. The toggle now uses async / await when calling to restore focus to the checkbox. Currently this works for closing but more work is needed for opening the dialog.
- I was also able to merge in the work for β¨ Scroll position is lost when refreshing the preview Fixed , though I only set the scrollPosition value just before calling a refresh, for better performance
- Changed the event listener for the toggle to use the 'change' event instead of 'click'
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Code is looking good. As we discussed on Slack, let's pull the scroll position part out and then it'll be RTBC. You can contribute that work to β¨ Scroll position is lost when refreshing the preview Fixed to keep that one moving. We'll get that piece in individually.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Looks good. Great improvement!
-
cosmicdreams β
committed 811caf65 on 2.0.x authored by
mandclu β
Issue #3352471 by mandclu: Checkbox with localStorage, trigger existing...
-
cosmicdreams β
committed 811caf65 on 2.0.x authored by
mandclu β
- Status changed to Fixed
over 1 year ago 10:06pm 7 April 2023 - Status changed to Fixed
over 1 year ago 10:49pm 25 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.