[1.0.x] Soft hyphen

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

1. Fix PHPCS issue.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml soft_hyphen/

FILE: soft_hyphen/soft_hyphen.module
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 19 | ERROR | [x] Concat operator must be surrounded by a single space
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

2. Replace README.txt with README.md file.

Please take a moment to make your README.md follow the guidelines.

3. FILE: soft_hyphen.info.yml

package: Custom

Modules should avoid using that value for the package.

I fixed the issues.

@attek25 If you changed what has been reported, please change the status to Needs review. In this way, reviewers will know everything has been changed and can be reviewed again.

If you want to take some time to check what you changed, that is fine. Just remember to change the status back when ready for the next review.

@attek25,

I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Thanks

@vishal.kadam Thanks a lot.

src/ShyTwigFilter.php

  public function shy(array|string $text): string {
    $string = '';
    if (is_array($text) && isset($text['#context']['value'])) {
      $string = $text['#context']['value'];
    }
    else {
      $string = $text;
    }

    $string = htmlspecialchars($string, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8');
    return str_replace('­', '­', $string);
  }

Drupal 9.3 still requires PHP 7.3, which does not allow a parameter to be defined as array|string $text. Either the minimum Drupal version is adjusted, or the module needs to declare its dependency from PHP 8, or the code is adjusted to be compatible with PHP 7.3.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Automatically closed - issue fixed for 2 weeks with no activity.