Plan for OneLogin SAML-PHP 4.1

Created on 4 April 2023, about 1 year ago
Updated 7 July 2023, 12 months ago

SAML PHP 4.1 was released in July 2022.
https://packagist.org/packages/onelogin/php-saml#4.1.0

Is there any plan make this module compatible with SAML PHP 4.1?

🌱 Plan
Status

Fixed

Version

4.0

Component

Code

Created by

🇦🇺Australia Mingsong 🇦🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Mingsong
  • 🇺🇸United States jproctor

    The PHP-SAML 4.x versions remove support for PHP 7.3, which is still allowed by Drupal 9 (until it reaches end of life in a few months). We cannot require 4.x until we stop supporting Drupal 9, which will be next year at the earliest.

    I’m running PHP-SAML 3.6.1 in PHP 8.1, so I don’t think there’s a serious compatibility issue, despite the release notes suggesting that isn’t added until 4.0.1. My guess, without chasing the code changes, is that this module does not touch any of the PHP-SAML code that needed to be updated. Do you have a specific need for the new $spValidationOnly feature introduced in PHP-SAML 4.1.0?

    I agree we should work on allowing 4.x, which will mostly amount to editing composer.json and testing to make sure it doesn’t break anything.

  • 🇦🇺Australia Mingsong 🇦🇺

    Thanks @Jae for your prompt reply.

  • First commit to issue fork.
  • @jrglasgow opened merge request.
  • Status changed to Fixed 12 months ago
  • 🇺🇸United States jrglasgow Idaho

    I tested on one of my sites allowing for onelogin/php-saml: ^3.3.1 | ^4.0 - 4.1.0 was installed and it works so I have committed.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024