Ajax throws the wrong error when failed

public function onException(ExceptionEvent $event) { $exception = $event->getThrowable(); $request = $event->getRequest(); // Render a nice error message in case we have a file upload which exceeds // the configured upload limit. if ($exception instanceof BrokenPostRequestException && $request->query->has(FormBuilderInterface::AJAX_FORM_REQUEST)) { $this->messenger->addError($this->t('An unrecoverable error occurred. The uploaded file likely exceeded the maximum file size (@size) that this server supports.', ['@size' => $this->formatSize($exception->getSize())])); $response = new AjaxResponse(NULL, 200); $status_messages = ['#type' => 'status_messages']; $response->addCommand(new PrependCommand(NULL, $status_messages)); $event->allowCustomResponseCode(); $event->setResponse($response); return; }

// In case the post request exceeds the configured allowed size // (post_max_size), the post request is potentially broken. Add some // protection against that and at the same time have a nice error message. if ($ajax_form_request && !$request->request->has('form_id')) { throw new BrokenPostRequestException($this->getFileUploadMaxSize()); }

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Issue created by @eduardo morales alberti
Comment over 1 year ago →
🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
I read

Given that the file upload limiit might exceed the $_POST limit or be near it, the actual rest of the form submitted data might be skipped so we need some protected against non valid submissions:

So I understand when the POST reaches the limit, the form_id is not set in the form submitted data. But this can be because of the file limit, or other errors, maybe should be the message more clear?
Comment over 1 year ago →
cilefen
It is difficult for Drupal to determine what happened when PHP truncates post data, because data is missing.
Comment over 1 year ago →
🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
And what about giving an error like "Missing data on ajax petition", it is more accurate.
Comment over 1 year ago →
cilefen
This is a similar issue: #2742371: Drag and drop interfaces can break either browsers or exceed PHP server limits for forms → .
Status changed to Closed: duplicate 7 months ago5:35pm 25 April 2024
Comment 7 months ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
This is a duplicate of 🐛 Error message presented when a BrokenPostRequestException is fired on AJAX submission can be misleading Needs work

Ajax throws the wrong error when failed

Problem/Motivation

Comments & Activities